Eduardo has uploaded a new change for review.
Change subject: Remove unused qemuImg.py. ......................................................................
Remove unused qemuImg.py.
Change-Id: Ib3ff2fe876a838306a15b6773aa810c8102e30fa Signed-off-by: Eduardo ewarszaw@redhat.com --- M vdsm.spec.in M vdsm/Makefile.am D vdsm/qemuImg.py 3 files changed, 0 insertions(+), 97 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/5582/1 -- To view, visit http://gerrit.ovirt.org/5582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ib3ff2fe876a838306a15b6773aa810c8102e30fa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Remove unused qemuImg.py. ......................................................................
Patch Set 1: I would prefer that you didn't submit this
I love removing code, but haven't we had high expectations of this module? wouldn't we want to replace all EXT_QEMUIMG references to calls to this module?
-- To view, visit http://gerrit.ovirt.org/5582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib3ff2fe876a838306a15b6773aa810c8102e30fa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Daniel Erez derez@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Eduardo has posted comments on this change.
Change subject: Remove unused qemuImg.py. ......................................................................
Patch Set 1:
This code is not in use. Deserve great expectations?
-- To view, visit http://gerrit.ovirt.org/5582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib3ff2fe876a838306a15b6773aa810c8102e30fa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Daniel Erez derez@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Remove unused qemuImg.py. ......................................................................
Patch Set 1: Do not submit
Nacking in light of: http://gerrit.ovirt.org/#/c/3841/17
-- To view, visit http://gerrit.ovirt.org/5582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib3ff2fe876a838306a15b6773aa810c8102e30fa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Daniel Erez derez@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Remove unused qemuImg.py. ......................................................................
Patch Set 1: Do not submit
I'm using it
-- To view, visit http://gerrit.ovirt.org/5582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib3ff2fe876a838306a15b6773aa810c8102e30fa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Daniel Erez derez@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Remove unused qemuImg.py. ......................................................................
Patch Set 1:
Please abandon
-- To view, visit http://gerrit.ovirt.org/5582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib3ff2fe876a838306a15b6773aa810c8102e30fa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Daniel Erez derez@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Eduardo has abandoned this change.
Change subject: Remove unused qemuImg.py. ......................................................................
Patch Set 1: Abandoned
-- To view, visit http://gerrit.ovirt.org/5582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: Ib3ff2fe876a838306a15b6773aa810c8102e30fa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Daniel Erez derez@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org