6:47 a.m.
New patch submitted by Saggi Mizrahi (smizrahi(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/888
commit d89f68cec7b1570a14decc0829503410479fd07a
Author: Saggi Mizrahi <smizrahi(a)redhat.com>
Date: Thu Sep 1 14:48:59 2011 +0300
BZ#??????? - MD offset should be in MD_SIZE not in bytes
Change-Id: I381f510e23027a24e889d33042f7523ac383cd41
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index ab3241f..f5995e5 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -549,7 +549,7 @@ class BlockStorageDomain(sd.StorageDomain):
continue
if size is None:
- size = blockVolume.VOLUME_METASIZE
+ size = 1
occupiedSlots.append((offset, size))
@@ -565,7 +565,7 @@ class BlockStorageDomain(sd.StorageDomain):
# metadata look the same. The domain might get
# confused and think it has lv metadata if it
# finds something is written in that area.
- freeSlot = SD_METADATA_SIZE
+ freeSlot = 1
for offset, size in occupiedSlots:
if offset - freeSlot > slotSize:
break
7:15 a.m.
New subject: Change in vdsm[master]: BZ#??????? - MD offset should be in MD_SIZE not in bytes
Saggi Mizrahi has abandoned this change.
Change subject: BZ#??????? - MD offset should be in MD_SIZE not in bytes
......................................................................
Patch Set 1: Abandoned
--
To view, visit http://gerrit.usersys.redhat.com/888
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I381f510e23027a24e889d33042f7523ac383cd41
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7:01 a.m.
New subject: Change in vdsm[master]: BZ#??????? - MD offset should be in MD_SIZE not in bytes
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#??????? - MD offset should be in MD_SIZE not in bytes
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 568: freeSlot = 1
Don't look for logic in the old way. It wasn't that well thought out.
Also just use SD_METADATA_SIZE/VOLUME_METASIZE
--
To view, visit http://gerrit.usersys.redhat.com/888
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I381f510e23027a24e889d33042f7523ac383cd41
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7 a.m.
New subject: Change in vdsm[master]: BZ#??????? - MD offset should be in MD_SIZE not in bytes
Federico Simoncelli has posted comments on this change.
Change subject: BZ#??????? - MD offset should be in MD_SIZE not in bytes
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 568: freeSlot = 1
Agreed to be 4. Change the SD_METADATA_SIZE value (not here).
--
To view, visit http://gerrit.usersys.redhat.com/888
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I381f510e23027a24e889d33042f7523ac383cd41
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:59 a.m.
New subject: Change in vdsm[master]: BZ#??????? - MD offset should be in MD_SIZE not in bytes
Federico Simoncelli has posted comments on this change.
Change subject: BZ#??????? - MD offset should be in MD_SIZE not in bytes
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 568: freeSlot = 1
Why the SD_METADATA_SIZE was planned to be 4 times bigger than the VOLUME_METASIZE? Is it
because it should hold more data? Let's not try to get this 4K compliant now...
because anyway the unit is block_size... so if bs=4K then it will be 8*4K.
--
To view, visit http://gerrit.usersys.redhat.com/888
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I381f510e23027a24e889d33042f7523ac383cd41
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:56 a.m.
New subject: Change in vdsm[master]: BZ#??????? - MD offset should be in MD_SIZE not in bytes
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#??????? - MD offset should be in MD_SIZE not in bytes
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 568: freeSlot = 1
Sorry 4, sdMD is 2K
--
To view, visit http://gerrit.usersys.redhat.com/888
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I381f510e23027a24e889d33042f7523ac383cd41
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:55 a.m.
New subject: Change in vdsm[master]: BZ#??????? - MD offset should be in MD_SIZE not in bytes
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#??????? - MD offset should be in MD_SIZE not in bytes
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm/storage/blockSD.py
Line 527: return self.getFreeMetadataSlot(blockVolume.VOLUME_METASIZE)
Yea, right
Line 568: freeSlot = 1
no, but it actually should be 8 4096/512
--
To view, visit http://gerrit.usersys.redhat.com/888
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I381f510e23027a24e889d33042f7523ac383cd41
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:52 a.m.
New subject: Change in vdsm[master]: BZ#??????? - MD offset should be in MD_SIZE not in bytes
Federico Simoncelli has posted comments on this change.
Change subject: BZ#??????? - MD offset should be in MD_SIZE not in bytes
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/blockSD.py
Line 527: return self.getFreeMetadataSlot(blockVolume.VOLUME_METASIZE)
I believe this should be 1.
Line 568: freeSlot = 1
This was correct I suppose. (not 4K compliant but correct).
--
To view, visit http://gerrit.usersys.redhat.com/888
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I381f510e23027a24e889d33042f7523ac383cd41
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
4619
days inactive
4619
days old
vdsm-patches@lists.fedorahosted.org
7 comments
2 participants
participants (2)
-
Federico Simoncelli -
smizrahi＠redhat.com