7:31 a.m.
mooli tayer has uploaded a new change for review.
Change subject: Text: add 'dstqemu' to vds client migration command description
......................................................................
Text: add 'dstqemu' to vds client migration command description
Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1007686
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M client/vdsClient.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/19277/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 590b1e7..bddfaa1 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -1957,8 +1957,8 @@
' name:value,name:value'
)),
'migrate': (serv.do_migrate,
- ('vmId=<id> method=<offline|online>
src=<host:[port]> '
- 'dst=<host:[port]>',
+ ('vmId=<id> method=<offline|online>
src=<host[:port]> '
+ 'dst=<host[:port]> dstqemu=<host[:port]>',
'Migrate a desktop from src machine to dst host using '
'the specified ports'
)),
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
7:37 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Text: add 'dstqemu' to vds client migration command description
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4477/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4396/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3580/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:59 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Text: add 'dstqemu' to vds client migration command description
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
File client/vdsClient.py
Line 1957: ' name:value,name:value'
Line 1958: )),
Line 1959: 'migrate': (serv.do_migrate,
Line 1960: ('vmId=<id> method=<offline|online>
src=<host[:port]> '
Line 1961: 'dst=<host[:port]>
dstqemu=<host[:port]>',
does dstqemu have a :port part? if so, it was unintentional, and I'm not sure I'd
like to document it.
Line 1962: 'Migrate a desktop from src machine to dst host using
'
Line 1963: 'the specified ports'
Line 1964: )),
Line 1965: 'migrateStatus': (serv.do_mStat,
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
4:09 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Text: add 'dstqemu' to vds client migration command description
......................................................................
Patch Set 2:
(1 comment)
....................................................
File client/vdsClient.py
Line 1957: ' name:value,name:value'
Line 1958: )),
Line 1959: 'migrate': (serv.do_migrate,
Line 1960: ('vmId=<id> method=<offline|online>
src=<host[:port]> '
Line 1961: 'dst=<host[:port]> dstqemu=<host>',
I'm not sure that port is not an optional parameter here.. can you verify that? it
should be able to be set.
any other missing fields that we don't know of as part of the migration network
feature (maybe mode and dstparams [http://www.ovirt.org/Features/Migration_Network])?
please check
thanks.
Line 1962: 'Migrate a desktop from src machine to dst host using
'
Line 1963: 'the specified ports'
Line 1964: )),
Line 1965: 'migrateStatus': (serv.do_mStat,
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
4:23 a.m.
mooli tayer has posted comments on this change.
Change subject: Text: add 'dstqemu' to vds client migration command description
......................................................................
Patch Set 2:
(1 comment)
....................................................
File client/vdsClient.py
Line 1957: ' name:value,name:value'
Line 1958: )),
Line 1959: 'migrate': (serv.do_migrate,
Line 1960: ('vmId=<id> method=<offline|online>
src=<host[:port]> '
Line 1961: 'dst=<host[:port]> dstqemu=<host>',
a.) as I understand dstqemu supports a port. Please see Dan's comment on the last
patch set, he asked that the port will be omitted from docs.
b.) This feature added no other new parameters, see:
http://www.ovirt.org/Features/Migration_Network#Vdsm
Line 1962: 'Migrate a desktop from src machine to dst host using
'
Line 1963: 'the specified ports'
Line 1964: )),
Line 1965: 'migrateStatus': (serv.do_mStat,
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
6:53 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Text: add 'dstqemu' to vds client migration command description
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4554/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3657/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4476/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:56 a.m.
Saggi Mizrahi has posted comments on this change.
Change subject: Text: add 'dstqemu' to vds client migration command description
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:04 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Text: add 'dstqemu' to vds client migration command description
......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4554/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4476/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3660/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:26 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Text: add 'dstqemu' to vds client migration command description
......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4554/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4476/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3665/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:18 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Text: add 'dstqemu' to vds client migration command description
......................................................................
Patch Set 2:
(1 comment)
....................................................
File client/vdsClient.py
Line 1957: ' name:value,name:value'
Line 1958: )),
Line 1959: 'migrate': (serv.do_migrate,
Line 1960: ('vmId=<id> method=<offline|online>
src=<host[:port]> '
Line 1961: 'dst=<host[:port]> dstqemu=<host>',
If port can be configurable it should be written here as optional parameter.
I see in the wiki "mode" field and wonder why it's not part of the described
variables.
Anyway, this not a new field, nor related to the patch as far as I understand.
Line 1962: 'Migrate a desktop from src machine to dst host using
'
Line 1963: 'the specified ports'
Line 1964: )),
Line 1965: 'migrateStatus': (serv.do_mStat,
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
1:56 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Text: add 'dstqemu' to vds client migration command description
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
....................................................
File client/vdsClient.py
Line 1957: ' name:value,name:value'
Line 1958: )),
Line 1959: 'migrate': (serv.do_migrate,
Line 1960: ('vmId=<id> method=<offline|online>
src=<host[:port]> '
Line 1961: 'dst=<host[:port]> dstqemu=<host>',
I asked Mooli to verify that specifying a port somehow work. If we are not sure we are ant
to support it, we should not doc it.
Line 1962: 'Migrate a desktop from src machine to dst host using
'
Line 1963: 'the specified ports'
Line 1964: )),
Line 1965: 'migrateStatus': (serv.do_mStat,
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: Yes
4:35 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: Text: add 'dstqemu' to vds client migration command description
......................................................................
Patch Set 2:
(1 comment)
....................................................
File client/vdsClient.py
Line 1957: ' name:value,name:value'
Line 1958: )),
Line 1959: 'migrate': (serv.do_migrate,
Line 1960: ('vmId=<id> method=<offline|online>
src=<host[:port]> '
Line 1961: 'dst=<host[:port]> dstqemu=<host>',
If modifying the port is supported I think its important to doc it as optional, and I
think it is - we sent the address to qemu as:
muri = 'tcp://%s' % self._vm.conf['_migrationParams']['dstqemu']
seems like tcp://1.1.1.1:888 will work here.
Line 1962: 'Migrate a desktop from src machine to dst host using
'
Line 1963: 'the specified ports'
Line 1964: )),
Line 1965: 'migrateStatus': (serv.do_mStat,
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: Yes
3:45 a.m.
mooli tayer has posted comments on this change.
Change subject: Text: add 'dstqemu' to vds client migration command description
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: No
4:38 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Text: add 'dstqemu' to vds client migration command description
......................................................................
Patch Set 2:
(1 comment)
....................................................
File client/vdsClient.py
Line 1957: ' name:value,name:value'
Line 1958: )),
Line 1959: 'migrate': (serv.do_migrate,
Line 1960: ('vmId=<id> method=<offline|online>
src=<host[:port]> '
Line 1961: 'dst=<host[:port]> dstqemu=<host>',
That's a big "if" that starts your sentence. With not verification, no
documentation, please.
Line 1962: 'Migrate a desktop from src machine to dst host using
'
Line 1963: 'the specified ports'
Line 1964: )),
Line 1965: 'migrateStatus': (serv.do_mStat,
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: Yes
4:38 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Text: add 'dstqemu' to vds client migration command description
......................................................................
Text: add 'dstqemu' to vds client migration command description
Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1007686
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/19277
Reviewed-by: Saggi Mizrahi <smizrahi(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M client/vdsClient.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Saggi Mizrahi: Looks good to me, but someone else must approve
mooli tayer: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
3858
days inactive
3874
days old
vdsm-patches@lists.fedorahosted.org
14 comments
5 participants
participants (5)
-
Dan Kenigsberg -
Jenkins CI RO -
mtayer＠redhat.com -
smizrahi＠redhat.com -
ybronhei＠redhat.com