From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: python3: Fix UUID packing/unpacking on python 3 ......................................................................
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/78632/9/tests/storage/misc_test.py File tests/storage/misc_test.py:
Line 459: return b.encode("hex") Line 460: Line 461: Line 462: # Note: packed values were generated by misc.packUuid(), to ensure that we keep Line 463: # the packed format.
Suggest a better way to test it?
a constant list of reproducible uuids (could be a seeded pseudo-random) Line 464: @pytest.mark.parametrize("bytes,packed", [ Line 465: # The smallest possible random value Line 466: (b"\x00" * 16, Line 467: b"\x00\x00\x00\x00\x00\x00\x00\x80\x00@\x00\x00\x00\x00\x00\x00"),
vdsm-patches@lists.fedorahosted.org