Saggi Mizrahi has uploaded a new change for review.
Change subject: [WIP] Support unicode in domain and pool description ......................................................................
[WIP] Support unicode in domain and pool description
Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e --- M vdsm/storage/dispatcher.py M vdsm/storage/persistentDict.py M vdsm/storage/sd.py M vdsm/storage/sp.py 4 files changed, 17 insertions(+), 31 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/637/1 -- To view, visit http://gerrit.ovirt.org/637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: [WIP] Support unicode in domain and pool description ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: [WIP] Support unicode in domain and pool description ......................................................................
Patch Set 3: Verified
-- To view, visit http://gerrit.ovirt.org/637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: [WIP] Support unicode in domain and pool description ......................................................................
Patch Set 4: I would prefer that you didn't submit this
How about breaking this into two stages: First, be able to read an report Unicode from metadata. This can be pushed now. Even to Z-stream.
Second, be able to accept and report Unicode. This should wait for the next metadata format change.
-- To view, visit http://gerrit.ovirt.org/637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: [WIP] Support unicode in domain and pool description ......................................................................
Patch Set 4:
unicode depends on domain version 3 support, this has no chance in getting into current rhel version
-- To view, visit http://gerrit.ovirt.org/637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Support unicode in domain and pool description ......................................................................
Patch Set 6: I would prefer that you didn't submit this
I know that this patch makes sure no one is writing Unicode in a domain version 2.
However, I'm suggesting a way were this could be possible - if 3.0.z is added the ability to report Unicode if it sees it.
Would you mind splitting this patch into two, so the reading part can be backported more easily?
-- To view, visit http://gerrit.ovirt.org/637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Support unicode in domain and pool description ......................................................................
Patch Set 6:
Version 2 can't support unicode. It makes an incompatible change to the on disk format.
I any case I don't think unicode descriptions are such a big deal anyway that we should take the risk of breaking clusters.
-- To view, visit http://gerrit.ovirt.org/637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Support unicode in domain and pool description ......................................................................
Patch Set 6: No score
I don't know if you did not understand or do not like my idea of enabling reading of utf8 first. Never mind.
-- To view, visit http://gerrit.ovirt.org/637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Peter V. Saveliev has posted comments on this change.
Change subject: Support unicode in domain and pool description ......................................................................
Patch Set 9: Verified
-- To view, visit http://gerrit.ovirt.org/637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Support unicode in domain and pool description ......................................................................
Patch Set 9: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Support unicode in domain and pool description ......................................................................
Support unicode in domain and pool description
Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e --- M vdsm/storage/blockSD.py M vdsm/storage/fileSD.py M vdsm/storage/localFsSD.py M vdsm/storage/misc.py M vdsm/storage/nfsSD.py M vdsm/storage/persistentDict.py M vdsm/storage/sd.py M vdsm/storage/sp.py 8 files changed, 58 insertions(+), 11 deletions(-)
Approvals: Dan Kenigsberg: Looks good to me, approved Peter V. Saveliev: Verified
-- To view, visit http://gerrit.ovirt.org/637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org