From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: handle handshake errors
......................................................................
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/79668/4//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2017-07-24 12:08:16 +0200
Line 6:
Line 7: ssl: handle handshake errors
Line 8:
Line 9: We need to make sure to close socket when handshake fails.
what happened otherwise?
Line 10:
Line 11:
Line 12: Bug-url:
https://bugzilla.redhat.com/1473295
Line 13: Change-Id: I99cfa35e608f429640455c35495be1783854e3da
https://gerrit.ovirt.org/#/c/79668/4/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 250: self.want_read = True
Line 251: elif err.args[0] == ssl.SSL_ERROR_WANT_WRITE:
Line 252: self.want_write = True
Line 253: else:
Line 254: dispatcher.close()
don't we need the above treatment ?
Line 255: except socket.error:
Line 256: dispatcher.close()
Line 257: else:
Line 258: self.want_read = self.want_write = True
--
To view, visit
https://gerrit.ovirt.org/79668
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99cfa35e608f429640455c35495be1783854e3da
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes