Change in vdsm[master]: deployUtil.py.in: setService() add support to restart vdsm d...

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: deployUtil.py.in: setService() add support to restart vdsm daemon on ovirt
Node
......................................................................

deployUtil.py.in: setService() add support to restart vdsm daemon on ovirt Node

vdm-complete script define reboot() which uses deployUtil.setService("vdsmd",
"restart")
However, deployUtil.setService() just execute the validation for initd script
(/etc/init.d/vdsmd), if the distro doesn't contain this file it fails and do
not execute the restart action.

Since vdsm.spec specify that if it's not RHEL we should use systemd,
this patch includes the validation for systemd vdsmd service.

Change-Id: I7c9d6e1aefa93e9fff067bf1153c0f555d247c64
---
M vdsm_reg/deployUtil.py.in
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/492/1
--
To view, visit http://gerrit.ovirt.org/492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c9d6e1aefa93e9fff067bf1153c0f555d247c64
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

Change in vdsm[master]: deployUtil.py.in: add support to restart vdsmd

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: deployUtil.py.in:  add support to restart vdsmd
......................................................................


Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c9d6e1aefa93e9fff067bf1153c0f555d247c64
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

Change in vdsm[master]: deployUtil.py.in: add support to restart vdsmd

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: deployUtil.py.in:  add support to restart vdsmd
......................................................................


Patch Set 3: Looks good to me, approved

patch looks sane, though there is a lot more work to be done until bootstraping works
correctly for Fedora.

--
To view, visit http://gerrit.ovirt.org/492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c9d6e1aefa93e9fff067bf1153c0f555d247c64
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: deployUtil.py.in: add support to restart vdsmd

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: deployUtil.py.in:  add support to restart vdsmd
......................................................................


deployUtil.py.in:  add support to restart vdsmd

vdsm-complete script define reboot() which uses deployUtil.setService("vdsmd",
"restart")
However, deployUtil.setService() just execute the validation for initd
script (/etc/init.d/vdsmd), if the distro doesn't contain this file it fails
and do not execute the restart action.

Since vdsm.spec specify that if it's not RHEL we should use systemd,
this patch includes the validation for systemd vdsmd service.

Change-Id: I7c9d6e1aefa93e9fff067bf1153c0f555d247c64
---
M vdsm_reg/deployUtil.py.in
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7c9d6e1aefa93e9fff067bf1153c0f555d247c64
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: deployUtil.py.in: add support to restart vdsmd

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: deployUtil.py.in:  add support to restart vdsmd
......................................................................


Patch Set 2: (1 inline comment)

....................................................
Commit Message
Line 9: vdm-complete script define reboot() which uses
deployUtil.setService("vdsmd", "restart")
Done

--
To view, visit http://gerrit.ovirt.org/492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c9d6e1aefa93e9fff067bf1153c0f555d247c64
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

Change in vdsm[master]: deployUtil.py.in: add support to restart vdsmd

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: deployUtil.py.in:  add support to restart vdsmd
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
Commit Message
Line 9: vdm-complete script define reboot() which uses
deployUtil.setService("vdsmd", "restart")
vdsm-complete

--
To view, visit http://gerrit.ovirt.org/492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c9d6e1aefa93e9fff067bf1153c0f555d247c64
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: deployUtil.py.in: setService() add support to restart vdsm daemon on ovirt
Node
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c9d6e1aefa93e9fff067bf1153c0f555d247c64
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;