Change in vdsm[master]: Makefile: add vdsm-reg-setup.in to pyflakes

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: Makefile: add vdsm-reg-setup.in to pyflakes
......................................................................

Makefile: add vdsm-reg-setup.in to pyflakes

We should run pyflakes in vdsm-reg-setup.in as well.

Change-Id: I6be99965f3249374c99c1d4ab71145d571c13921
Signed-off-by: Douglas Schilling Landgraf 
---
M Makefile.am
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/27025/1

diff --git a/Makefile.am b/Makefile.am
index a7fc23f..ea3a4c3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -66,7 +66,8 @@

check-local:
    find . -path './.git' -prune -type f -o \
-		-name '*.py' -o -name '*.py.in'  | xargs $(PYFLAKES) | \
+		-name '*.py' -o -name '*.py.in' -o \
+		-name 'vdsm-reg-setup.in' | xargs $(PYFLAKES) | \
    	grep -w -v $(SKIP_PYFLAKES_ERR) | \
    	while read LINE; do echo "$$LINE"; false; done
    $(PEP8) --version

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Makefile: add vdsm-reg-setup.in to pyflakes
......................................................................

Patch Set 1: Verified+1

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Makefile: add vdsm-reg-setup.in to pyflakes
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8269/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7479/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8387/ : SUCCESS

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Makefile: add vdsm-reg-setup.in to pyflakes
......................................................................

Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/27025/1/Makefile.am
File Makefile.am:

Line 63: 
Line 64: SKIP_PYFLAKES_ERR = "./vdsm/storage/lvm.py.*: list comprehension redefines \
Line 65: 	'lv' from line .*"
Line 66: 
Line 67: check-local:
precede "find" with

echo /path/to/vdsm-reg-setup.in && \

to have a simpler "find". Please search other scripts that should better be pyflakesed. Consider adding them to PEP8, too.
Line 68: 	find . -path './.git' -prune -type f -o \
Line 69: 		-name '*.py' -o -name '*.py.in' -o \
Line 70: 		-name 'vdsm-reg-setup.in' | xargs $(PYFLAKES) | \
Line 71: 		grep -w -v $(SKIP_PYFLAKES_ERR) | \

Itamar Heim has posted comments on this change.

Change subject: Makefile: add vdsm-reg-setup.in to pyflakes
......................................................................

Patch Set 1:

ping

Change in vdsm[master]: Makefile: add whitelist files to pyflakes and pep8 check

Yaniv Bronhaim has posted comments on this change.

Change subject: Makefile: add whitelist files to pyflakes and pep8 check
......................................................................

Patch Set 2: Verified+1

Change in vdsm[master]: Makefile: add whitelist files to pyflakes and pep8 check

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Makefile: add whitelist files to pyflakes and pep8 check
......................................................................

Patch Set 2:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13480/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13318/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12528/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/91/ : FAILURE

Change in vdsm[master]: Makefile: add whitelist files to pyflakes and pep8 check

Dima Kuznetsov has posted comments on this change.

Change subject: Makefile: add whitelist files to pyflakes and pep8 check
......................................................................

Patch Set 2: Code-Review+1

Change in vdsm[master]: Makefile: add whitelist files to pyflakes and pep8 check

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Makefile: add whitelist files to pyflakes and pep8 check
......................................................................

Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/27025/2/Makefile.am
File Makefile.am:

Line 90: 	      echo "Missing $${i%%.in} in .gitignore"; exit 1; fi; \
Line 91: 	  done; \
Line 92: 	fi;
Line 93: 
Line 94: EXT_FILES = \
Why are these defined?
Line 95: 	vdsm_reg/vdsm-reg-setup.in \
Line 96: 	$(NULL)
Line 97: 
Line 98: SKIP_PYFLAKES_ERR = "./vdsm/storage/lvm.py.*: list comprehension redefines \

Change in vdsm[master]: Makefile: add whitelist files to pyflakes and pep8 check

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Makefile: add whitelist files to pyflakes and pep8 check
......................................................................

Patch Set 2: Code-Review-1

Setting -1 for visibility

Change in vdsm[master]: Makefile: add whitelist files to pyflakes and pep8 check

Yaniv Bronhaim has posted comments on this change.

Change subject: Makefile: add whitelist files to pyflakes and pep8 check
......................................................................

Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/27025/2/Makefile.am
File Makefile.am:

Line 90: 	      echo "Missing $${i%%.in} in .gitignore"; exit 1; fi; \
Line 91: 	  done; \
Line 92: 	fi;
Line 93: 
Line 94: EXT_FILES = \
> Why are these defined?

damn leftover.. sorry
Line 95: 	vdsm_reg/vdsm-reg-setup.in \
Line 96: 	$(NULL)
Line 97: 
Line 98: SKIP_PYFLAKES_ERR = "./vdsm/storage/lvm.py.*: list comprehension redefines \

Change in vdsm[master]: Makefile: add whitelist files to pyflakes and pep8 check

Yaniv Bronhaim has posted comments on this change.

Change subject: Makefile: add whitelist files to pyflakes and pep8 check
......................................................................

Patch Set 3: Verified+1

Change in vdsm[master]: Makefile: add whitelist files to pyflakes and pep8 check

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Makefile: add whitelist files to pyflakes and pep8 check
......................................................................

Patch Set 3:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13381/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12591/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/157/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13543/ : FAILURE

Change in vdsm[master]: Makefile: add whitelist files to pyflakes and pep8 check

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Makefile: add whitelist files to pyflakes and pep8 check
......................................................................

Patch Set 3: Code-Review+2

Change in vdsm[master]: Makefile: add whitelist files to pyflakes and pep8 check

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Makefile: add whitelist files to pyflakes and pep8 check
......................................................................

Makefile: add whitelist files to pyflakes and pep8 check

We should run pyflakes and pep8 check in vdsm-reg-setup.in for example.
We already have whitelist for pep8. this adds the files also to pyflakes
check.

Change-Id: I6be99965f3249374c99c1d4ab71145d571c13921
Signed-off-by: Douglas Schilling Landgraf 
Signed-off-by: Yaniv Bronhaim 
Reviewed-on: http://gerrit.ovirt.org/27025
Reviewed-by: Dan Kenigsberg 
---
M Makefile.am
1 file changed, 7 insertions(+), 4 deletions(-)

Approvals:
  Yaniv Bronhaim: Verified
  Dan Kenigsberg: Looks good to me, approved

Change in vdsm[master]: Makefile: add whitelist files to pyflakes and pep8 check

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Makefile: add whitelist files to pyflakes and pep8 check
......................................................................

Patch Set 4:

Build Successful

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/203/ : SUCCESS