10 a.m.
ShaoHe Feng has uploaded a new change for review.
Change subject: fix the logging method format of deployUtil
......................................................................
fix the logging method format of deployUtil
Change-Id: If5cd28b33aa842cbb7510c284f368dd1170b8b10
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
---
M vdsm_reg/deployUtil.py.in
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/5381/1
--
To view, visit http://gerrit.ovirt.org/5381
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5cd28b33aa842cbb7510c284f368dd1170b8b10
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
1:24 a.m.
New subject: Change in vdsm[master]: fix logging method format
Dan Kenigsberg has submitted this change and it was merged.
Change subject: fix logging method format
......................................................................
fix logging method format
Change-Id: If5cd28b33aa842cbb7510c284f368dd1170b8b10
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
---
M vdsm/configNetwork.py
M vdsm/utils.py
M vdsm_reg/deployUtil.py.in
3 files changed, 15 insertions(+), 15 deletions(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
ShaoHe Feng: Verified
Bing Bu Cao: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5381
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5cd28b33aa842cbb7510c284f368dd1170b8b10
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
12:13 a.m.
New subject: Change in vdsm[master]: fix logging method format
ShaoHe Feng has posted comments on this change.
Change subject: fix logging method format
......................................................................
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/5381
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5cd28b33aa842cbb7510c284f368dd1170b8b10
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
9:51 a.m.
New subject: Change in vdsm[master]: fix logging method format
Douglas Schilling Landgraf has posted comments on this change.
Change subject: fix logging method format
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5381
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5cd28b33aa842cbb7510c284f368dd1170b8b10
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
2:18 a.m.
New subject: Change in vdsm[master]: fix logging method format
Bing Bu Cao has posted comments on this change.
Change subject: fix logging method format
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5381
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5cd28b33aa842cbb7510c284f368dd1170b8b10
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
3:55 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: fix the logging method format of deployUtil
......................................................................
Patch Set 1:
I believe you could join your 3 patches into one - it is better to split patches by topic,
not by file.
--
To view, visit http://gerrit.ovirt.org/5381
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5cd28b33aa842cbb7510c284f368dd1170b8b10
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
2:21 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: fix the logging method format of deployUtil
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm_reg/deployUtil.py.in
Line 1406: logging.error("Failed to fetch %s status %s", (fileName,
status))
the string expects 2 args, but there's only one (tuple).
--
To view, visit http://gerrit.ovirt.org/5381
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5cd28b33aa842cbb7510c284f368dd1170b8b10
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
3:08 a.m.
New subject: Change in vdsm[master]: fix logging method format
Dan Kenigsberg has posted comments on this change.
Change subject: fix logging method format
......................................................................
Patch Set 2: Looks good to me, approved
(1 inline comment)
....................................................
File vdsm_reg/deployUtil.py.in
Line 1398: fileName, str(response.status), response.reason)
this call to str() is redundant.
--
To view, visit http://gerrit.ovirt.org/5381
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5cd28b33aa842cbb7510c284f368dd1170b8b10
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
4336
days inactive
4354
days old
vdsm-patches@lists.fedorahosted.org
7 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Douglas Schilling Landgraf -
mars＠linux.vnet.ibm.com -
shaohef＠linux.vnet.ibm.com