Change in vdsm[master]: tests: declate alignmentScanTests as broken

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: tests: declate alignmentScanTests as broken
......................................................................

tests: declate alignmentScanTests as broken

More often then not,

    alignmentScanTests.AlignmentScanTests.test_aligned_image
    alignmentScanTests.AlignmentScanTests.test_unaligned_image

fail on our Jenkins slaves with the message

    libguestfs: error: could not connect to libvirt (URI = NULL): Failed to connect socket
to '/run/user/1001/libvirt/libvirt-sock': Permission denied [code=38 domain=7]

Mark them as broken until we understand the issue better.

Change-Id: Ic64c0c5a19c5b207ef6c00fcbb247ac39d975a88
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M tests/alignmentScanTests.py
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/21871/1

diff --git a/tests/alignmentScanTests.py b/tests/alignmentScanTests.py
index 8208b19..599f1b4 100644
--- a/tests/alignmentScanTests.py
+++ b/tests/alignmentScanTests.py
@@ -24,7 +24,7 @@
 from nose.tools import eq_, raises
 from nose.plugins.skip import SkipTest
 from testrunner import VdsmTestCase as TestCaseBase
-from testValidation import slowtest
+from testValidation import brokentest, slowtest
 from storage.misc import execCmd
 from alignmentScan import runScanArgs, scanImage, VirtAlignError
 
@@ -57,6 +57,7 @@
         scanImage("nonexistent-image-name")
 
     @slowtest
+    @brokentest("libguestfs occasionally fails to open libvirt-sock")
     def test_nonaligned_image(self):
         validate_virtalignscan_installed()
         with tempfile.NamedTemporaryFile() as img:
@@ -67,6 +68,7 @@
             eq_(msg[0][4], 'bad (alignment < 4K)')
 
     @slowtest
+    @brokentest("libguestfs occasionally fails to open libvirt-sock")
     def test_aligned_image(self):
         validate_virtalignscan_installed()
         with tempfile.NamedTemporaryFile() as img:


-- 
To view, visit http://gerrit.ovirt.org/21871
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic64c0c5a19c5b207ef6c00fcbb247ac39d975a88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: declate alignmentScanTests as broken
......................................................................


Patch Set 1: Verified+1 Code-Review+2

I've had enough of those false negatives.

-- 
To view, visit http://gerrit.ovirt.org/21871
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64c0c5a19c5b207ef6c00fcbb247ac39d975a88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: declate alignmentScanTests as broken
......................................................................


tests: declate alignmentScanTests as broken

More often then not,

    alignmentScanTests.AlignmentScanTests.test_aligned_image
    alignmentScanTests.AlignmentScanTests.test_unaligned_image

fail on our Jenkins slaves with the message

    libguestfs: error: could not connect to libvirt (URI = NULL): Failed to connect socket
to '/run/user/1001/libvirt/libvirt-sock': Permission denied [code=38 domain=7]

Mark them as broken until we understand the issue better.

Change-Id: Ic64c0c5a19c5b207ef6c00fcbb247ac39d975a88
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/21871
Reviewed-by: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
---
M tests/alignmentScanTests.py
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21871
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic64c0c5a19c5b207ef6c00fcbb247ac39d975a88
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Antoni Segura Puimedon has posted comments on this change.

Change subject: tests: declate alignmentScanTests as broken
......................................................................


Patch Set 1: Code-Review+1

Since there are more reports than just jenkins, I switch my vote.

-- 
To view, visit http://gerrit.ovirt.org/21871
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64c0c5a19c5b207ef6c00fcbb247ac39d975a88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: declate alignmentScanTests as broken
......................................................................


Patch Set 1:

Nir Soffer reported on infra@ovirt that he she's this on his own hosts.

Surely this deserve more research.

-- 
To view, visit http://gerrit.ovirt.org/21871
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64c0c5a19c5b207ef6c00fcbb247ac39d975a88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: tests: declate alignmentScanTests as broken
......................................................................


Patch Set 1:

>  I would personally prefer to have a modification of the jenkins job
> that does NOSE_EXCLUDE on these two tests, since I'm not aware of anybodies pc failing
> the tests. 
These tests fails randomly on my hosts - this is not a jenkins issue.

-- 
To view, visit http://gerrit.ovirt.org/21871
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64c0c5a19c5b207ef6c00fcbb247ac39d975a88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Antoni Segura Puimedon has posted comments on this change.

Change subject: tests: declate alignmentScanTests as broken
......................................................................


Patch Set 1:

I will contact dcaro about it.

-- 
To view, visit http://gerrit.ovirt.org/21871
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64c0c5a19c5b207ef6c00fcbb247ac39d975a88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Antoni Segura Puimedon has posted comments on this change.

Change subject: tests: declate alignmentScanTests as broken
......................................................................


Patch Set 1: Code-Review-1

I would personally prefer to have a modification of the jenkins job that does NOSE_EXCLUDE
on these two tests, since I'm not aware of anybodies pc failing the tests.

-- 
To view, visit http://gerrit.ovirt.org/21871
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64c0c5a19c5b207ef6c00fcbb247ac39d975a88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: declate alignmentScanTests as broken
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5826/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5918/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5030/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/21871
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64c0c5a19c5b207ef6c00fcbb247ac39d975a88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No