Change in vdsm[master]: Various fixes for partitioned devices.

Eduardo has uploaded a new change for review.

Change subject: Various fixes for partitioned devices.
......................................................................

Various fixes for partitioned devices.

Change-Id: Ia3da9a5bd8d419b0930804dd6c9ca3e263b70eca
Signed-off-by: Eduardo <ewarszaw(a)redhat.com&gt;
---
M vdsm/storage/devicemapper.py
M vdsm/storage/hsm.py
M vdsm/storage/multipath.py
3 files changed, 9 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/5189/1
--
To view, visit http://gerrit.ovirt.org/5189
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3da9a5bd8d419b0930804dd6c9ca3e263b70eca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;

Change in vdsm[master]: Report devices that probaly will fail if pvcreated.

Eduardo has abandoned this change.

Change subject: Report devices that probaly will fail if pvcreated.
......................................................................


Patch Set 2: Abandoned

Superseded Change I6af6628a

--
To view, visit http://gerrit.ovirt.org/5189
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia3da9a5bd8d419b0930804dd6c9ca3e263b70eca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

Change in vdsm[master]: Report devices that probaly will fail if pvcreated.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Report devices that probaly will fail if pvcreated.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/devicemapper.py
Line 124:     possiblePartPath = os.path.join("/dev/mapper/", devName +
"p1")
one of the two - comment or /dev/mapper usage - must go.

--
To view, visit http://gerrit.ovirt.org/5189
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3da9a5bd8d419b0930804dd6c9ca3e263b70eca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Various fixes for partitioned devices.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File vdsm/storage/devicemapper.py
Line 107:     #Sometimes partitions are not managed by device mapper
you have just made this comment stale. it is about *not* using dev/mapper to catch the
partition. git-blame does not give too much info, but please ask S or Paikov if they
recall the issue.

....................................................
File vdsm/storage/hsm.py
Line 1540:                 except se.StorageException:
unrelated change, right?

....................................................
File vdsm/storage/multipath.py
Line 344:         if not "mpath-" in uuid:
why change a quick search into a long one?

--
To view, visit http://gerrit.ovirt.org/5189
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3da9a5bd8d419b0930804dd6c9ca3e263b70eca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt;

Daniel Erez has posted comments on this change.

Change subject: Various fixes for partitioned devices.
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/5189
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3da9a5bd8d419b0930804dd6c9ca3e263b70eca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt;

Eduardo has posted comments on this change.

Change subject: Various fixes for partitioned devices.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 1540:                 except se.StorageException:
The relatedness is in the eyes of the observer.

--
To view, visit http://gerrit.ovirt.org/5189
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3da9a5bd8d419b0930804dd6c9ca3e263b70eca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;

Eduardo has posted comments on this change.

Change subject: Various fixes for partitioned devices.
......................................................................


Patch Set 1: (3 inline comments)

....................................................
File vdsm/storage/devicemapper.py
Line 107:     #Sometimes partitions are not managed by device mapper
Please discuss it with him.

....................................................
File vdsm/storage/hsm.py
Line 1540:                 except se.StorageException:
Was more confusing before IMHO.

....................................................
File vdsm/storage/multipath.py
Line 344:         if not "mpath-" in uuid:
Yes.

--
To view, visit http://gerrit.ovirt.org/5189
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3da9a5bd8d419b0930804dd6c9ca3e263b70eca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Various fixes for partitioned devices.
......................................................................


Patch Set 1: (3 inline comments)

....................................................
File vdsm/storage/devicemapper.py
Line 107:     #Sometimes partitions are not managed by device mapper
I cherish Ayal as a person, but "Ayal wants it" is not a valid argument here in
the open.

I start to suspect that the author of this line wrote it (and its comment) intentionally.
You'd need better reasoning to convince me that you're doing the right thing.

....................................................
File vdsm/storage/hsm.py
Line 1540:                 except se.StorageException:
I'm not saying it's not clearer, I'm saying its unrelated to this patch, and
confusing.
Am I right?

....................................................
File vdsm/storage/multipath.py
Line 344:         if not "mpath-" in uuid:
Do we really want to iterate over partition devices? (I suppose that
part1-mpath-1derezkiril22 is one)

--
To view, visit http://gerrit.ovirt.org/5189
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3da9a5bd8d419b0930804dd6c9ca3e263b70eca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;

Eduardo has posted comments on this change.

Change subject: Various fixes for partitioned devices.
......................................................................


Patch Set 1: (3 inline comments)

....................................................
File vdsm/storage/devicemapper.py
Line 107:     #Sometimes partitions are not managed by device mapper
I raised the same issue, but this is the way Ayal wants it.

....................................................
File vdsm/storage/hsm.py
Line 1540:                 except se.StorageException:
Is clear this way. May be "continue" can raise? ;)

....................................................
File vdsm/storage/multipath.py
Line 344:         if not "mpath-" in uuid:
# cat /sys/block/dm-26/dm/uuid: 
part1-mpath-1derezkiril22

--
To view, visit http://gerrit.ovirt.org/5189
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3da9a5bd8d419b0930804dd6c9ca3e263b70eca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;