Federico Simoncelli has uploaded a new change for review.
Change subject: BZ#844294 Add requiresMailbox to StorageDomain ......................................................................
BZ#844294 Add requiresMailbox to StorageDomain
Since commit 942c2dc the storage domain objects are all DomainProxy instances, but the method StoragePool.__createMailboxMonitor was still relying on identifying the object type to activate the HSM mailbox.
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: If26f06102b2ca54ee6fdb2cd617302b0b1ccbea7 --- M vdsm/storage/blockSD.py M vdsm/storage/sd.py M vdsm/storage/sp.py 3 files changed, 14 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/6754/1 -- To view, visit http://gerrit.ovirt.org/6754 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: If26f06102b2ca54ee6fdb2cd617302b0b1ccbea7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#844294 Add requiresMailbox to StorageDomain ......................................................................
Patch Set 1: Looks good to me, approved
You are a god
-- To view, visit http://gerrit.ovirt.org/6754 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If26f06102b2ca54ee6fdb2cd617302b0b1ccbea7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: BZ#844294 Add requiresMailbox to StorageDomain ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6754 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If26f06102b2ca54ee6fdb2cd617302b0b1ccbea7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Haim Ateya has posted comments on this change.
Change subject: BZ#844294 Add requiresMailbox to StorageDomain ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/6754 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If26f06102b2ca54ee6fdb2cd617302b0b1ccbea7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#844294 Add requiresMailbox to StorageDomain ......................................................................
BZ#844294 Add requiresMailbox to StorageDomain
Since commit 942c2dc the storage domain objects are all DomainProxy instances, but the method StoragePool.__createMailboxMonitor was still relying on identifying the object type to activate the HSM mailbox.
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: If26f06102b2ca54ee6fdb2cd617302b0b1ccbea7 --- M vdsm/storage/blockSD.py M vdsm/storage/sd.py M vdsm/storage/sp.py 3 files changed, 14 insertions(+), 4 deletions(-)
Approvals: Ayal Baron: Looks good to me, approved Saggi Mizrahi: Looks good to me, approved Haim Ateya: Verified Dan Kenigsberg:
-- To view, visit http://gerrit.ovirt.org/6754 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: If26f06102b2ca54ee6fdb2cd617302b0b1ccbea7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org