Change in vdsm[master]: schema: Remove VmFullStatus

Adam Litke has uploaded a new change for review.

Change subject: schema: Remove VmFullStatus
......................................................................

schema: Remove VmFullStatus

The VmFullStatus alias is a meaningless indirection that simply causes confusion
to API users.  In all cases, its use just means VmDefinition so use that type
instead.

Change-Id: Id16979a105521e3c059ba27029493b71158f8815
Signed-off-by: Adam Litke 
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 2 insertions(+), 11 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/8613/1

diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 5d4e10f..3f8f0a0 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -2394,15 +2394,6 @@
           'vmType': 'VmType'}}

##
-# @VmFullStatus:
-#
-# A VmFullStatus uses the same format as a VmDefinition.
-#
-# Since: 4.10.0
-##
-{'alias': 'VmFullStatus', 'data': 'VmDefinition'}
-
-##
 # @VmInfo:
 #
 # A discriminated record of VM status information.
@@ -2413,7 +2404,7 @@
 ##
 {'type': 'VmInfo',
  'data': {},
- 'union': ['VmFullStatus', 'VmShortStatus']}
+ 'union': ['VmDefinition', 'VmShortStatus']}

##
 # @Host.getVMList:
@@ -4910,7 +4901,7 @@
 # Since: 4.10.0
 ##
 {'type': 'MigrationCreateState',
- 'data': {'migrationPort': 'int', 'params': 'VmFullStatus'}}
+ 'data': {'migrationPort': 'int', 'params': 'VmDefinition'}}

##
 # @VM.migrationCreate:

--
To view, visit http://gerrit.ovirt.org/8613
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id16979a105521e3c059ba27029493b71158f8815
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke

Royce Lv has posted comments on this change.

Change subject: schema: Remove VmFullStatus
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8613
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id16979a105521e3c059ba27029493b71158f8815
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Royce Lv

Saggi Mizrahi has posted comments on this change.

Change subject: schema: Remove VmFullStatus
......................................................................

Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/8613
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id16979a105521e3c059ba27029493b71158f8815
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Saggi Mizrahi

Adam Litke has posted comments on this change.

Change subject: schema: Remove VmFullStatus
......................................................................

Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/8613
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id16979a105521e3c059ba27029493b71158f8815
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: schema: Remove VmFullStatus
......................................................................

schema: Remove VmFullStatus

The VmFullStatus alias is a meaningless indirection that simply causes confusion
to API users.  In all cases, its use just means VmDefinition so use that type
instead.

Change-Id: Id16979a105521e3c059ba27029493b71158f8815
Signed-off-by: Adam Litke 
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 2 insertions(+), 11 deletions(-)

Approvals:
  Adam Litke: Verified
  Saggi Mizrahi: Looks good to me, approved
  Dan Kenigsberg:

--
To view, visit http://gerrit.ovirt.org/8613
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id16979a105521e3c059ba27029493b71158f8815
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Saggi Mizrahi