Change in vdsm[master]: lvm: Make the isActiveLV() method public.

Lee Yarwood has uploaded a new change for review.

Change subject: lvm: Make the isActiveLV() method public.
......................................................................

lvm: Make the isActiveLV() method public.

This change makes the private isActiveLV() method public for
use in the blockSD layer.

Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec
Signed-off-by: Lee Yarwood 
---
M vdsm/storage/lvm.py
1 file changed, 1 insertion(+), 3 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/21386/1

diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 112f1c0..76184b8 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -1221,10 +1221,8 @@
     return os.path.basename(os.readlink(lvp))

-def _isLVActive(vgName, lvName):
+def isLVActive(vgName, lvName):
     """Active volumes have a mp link.
-
-    This function should not be used out of this module.
     """
     return os.path.exists(lvPath(vgName, lvName))

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: lvm: Make the isActiveLV() method public.
......................................................................

Patch Set 1: Verified-1

Build Failed

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4688/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5488/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5567/ : FAILURE

Change in vdsm[master]: lvm: Make the isLVActive() method public.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: lvm: Make the isLVActive() method public.
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4690/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5490/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5569/ : SUCCESS

Change in vdsm[master]: lvm: Make the isLVActive() method public.

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: lvm: Make the isLVActive() method public.
......................................................................

Patch Set 2:

(1 comment)

....................................................
Commit Message
Line 6: 
Line 7: lvm: Make the isLVActive() method public.
Line 8: 
Line 9: This change makes the private isLVActive() method public for
Line 10: use in the blockSD layer.
Please explain why the block layer needs this - activating lvs more precisely, avoiding activation of active lvs, etc.
Line 11: 
Line 12: Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec

Change in vdsm[master]: lvm: Make the isLVActive() method public.

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: lvm: Make the isLVActive() method public.
......................................................................

Patch Set 2:

(1 comment)

....................................................
Commit Message
Line 7: lvm: Make the isLVActive() method public.
Line 8: 
Line 9: This change makes the private isLVActive() method public for
Line 10: use in the blockSD layer.
Line 11: 
Add note that this is patch 2 of 3 - all must be merged to fix this bug.

Add bug-url
Line 12: Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec

Change in vdsm[master]: lvm: Make the isLVActive() method public.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: lvm: Make the isLVActive() method public.
......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4698/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5498/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5577/ : SUCCESS

Change in vdsm[master]: lvm: Make the isLVActive() method public.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: lvm: Make the isLVActive() method public.
......................................................................

Patch Set 4:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4699/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5499/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5578/ : SUCCESS

Change in vdsm[master]: lvm: Make the isLVActive() method public.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: lvm: Make the isLVActive() method public.
......................................................................

Patch Set 5: Verified-1

Build Failed

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4703/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5503/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5582/ : FAILURE

Change in vdsm[master]: lvm: Make the isLVActive() method public.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: lvm: Make the isLVActive() method public.
......................................................................

Patch Set 6:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4704/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5504/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5583/ : SUCCESS

Change in vdsm[master]: lvm: Make the isLVActive() method public.

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: lvm: Make the isLVActive() method public.
......................................................................

Patch Set 6: Code-Review+1

Change in vdsm[master]: lvm: Make the isLVActive() method public.

[Allon Mureinik]

Allon Mureinik has posted comments on this change.

Change subject: lvm: Make the isLVActive() method public.
......................................................................

Patch Set 6: Code-Review+1

Change in vdsm[master]: lvm: Make the isLVActive() method public.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: lvm: Make the isLVActive() method public.
......................................................................

Patch Set 7:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4777/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5577/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5660/ : SUCCESS

Change in vdsm[master]: lvm: Make the isLVActive() method public.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: lvm: Make the isLVActive() method public.
......................................................................

Patch Set 8:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4778/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5578/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5661/ : SUCCESS

Change in vdsm[master]: lvm: Make the isLVActive() method public.

Itamar Heim has posted comments on this change.

Change subject: lvm: Make the isLVActive() method public.
......................................................................

Patch Set 8:

ping - still relevant?

Change in vdsm[master]: lvm: Make the isLVActive() method public.

Lee Yarwood has abandoned this change.

Change subject: lvm: Make the isLVActive() method public.
......................................................................

Abandoned