Change in vdsm[master]: Remove redundant ifupping of bonded ifaces.

Antoni Segura Puimedon has uploaded a new change for review.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Remove redundant ifupping of bonded ifaces.

ifup-eth of initscripts, when ifupping a bond checks which are
its slaves and ifups them. Thus, removing this two ifup places
we avoid a big source of FAILED messages in our logs while
keeping all the functionality and correctness.

Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Signed-off-by: Antoni S. Puimedon 
---
M vdsm/configNetwork.py
1 file changed, 5 insertions(+), 9 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/10009/1

diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py
index 711a0d4..def9f34 100755
--- a/vdsm/configNetwork.py
+++ b/vdsm/configNetwork.py
@@ -1004,11 +1004,11 @@
     # Now we can run ifup for all interfaces
     if bonding:
         ifup(bonding, bondBootproto == 'dhcp' and not blockingDhcp)
-
-    # NICs must be activated in the same order of boot time
-    # to expose the correct MAC address.
-    for nic in nicSort(nics):
-        ifup(nic, options.get('bootproto') == 'dhcp' and not blockingDhcp)
+    else:
+        # NICs must be activated in the same order of boot time
+        # to expose the correct MAC address.
+        for nic in nicSort(nics):
+            ifup(nic, options.get('bootproto') == 'dhcp' and not blockingDhcp)

# Now we can ifup VLAN interface, because bond and nic already up
     if vlan:
@@ -1266,10 +1266,6 @@

# Now we can run ifup for all interfaces
         ifup(bond)
-        # NICs must be activated in the same order of boot time
-        # to expose the correct MAC address.
-        for nic in nicSort(bondAttrs['nics']):
-            ifup(nic)

def _removeBondings(bondings, configWriter):

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/348/ (2/2)

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/314/ (1/2)

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/314/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/348/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

could you ask Meni to verify that this (after dropping nicSort) has no regressions? it sounds too good to be true..

....................................................
File vdsm/configNetwork.py
Line 1003: 
Line 1004:     # Now we can run ifup for all interfaces
Line 1005:     if bonding:
Line 1006:         ifup(bonding, bondBootproto == 'dhcp' and not blockingDhcp)
Line 1007:     else:
if not bonding:
  there is only one nic, so there is no point in nicSort'ing.
Line 1008:         # NICs must be activated in the same order of boot time
Line 1009:         # to expose the correct MAC address.
Line 1010:         for nic in nicSort(nics):
Line 1011:             ifup(nic, options.get('bootproto') == 'dhcp' and not blockingDhcp)

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Antoni Segura Puimedon has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 1003: 
Line 1004:     # Now we can run ifup for all interfaces
Line 1005:     if bonding:
Line 1006:         ifup(bonding, bondBootproto == 'dhcp' and not blockingDhcp)
Line 1007:     else:
Oh, I was considering the possibility of a bridge with two nics, for example, but I guess we don't support that use case of using that host as a networking bridge.
Line 1008:         # NICs must be activated in the same order of boot time
Line 1009:         # to expose the correct MAC address.
Line 1010:         for nic in nicSort(nics):
Line 1011:             ifup(nic, options.get('bootproto') == 'dhcp' and not blockingDhcp)

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Mark Wu has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 1003: 
Line 1004:     # Now we can run ifup for all interfaces
Line 1005:     if bonding:
Line 1006:         ifup(bonding, bondBootproto == 'dhcp' and not blockingDhcp)
Line 1007:     else:
I don't think we could get a use case of two nics connected to one bridge either.
Line 1008:         # NICs must be activated in the same order of boot time
Line 1009:         # to expose the correct MAC address.
Line 1010:         for nic in nicSort(nics):
Line 1011:             ifup(nic, options.get('bootproto') == 'dhcp' and not blockingDhcp)

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/384/ (1/2)

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/350/ (2/2)

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/350/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/384/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/configNetwork.py
Line 1005:     if bonding:
Line 1006:         ifup(bonding, bondBootproto == 'dhcp' and not blockingDhcp)
Line 1007:     else:
Line 1008:         # NICs must be activated in the same order of boot time
Line 1009:         # to expose the correct MAC address.
I think I was misunderstood - when there is no bonding, there's only 0 or one nics. The "for" loop is a bit misleading, and the comment is plain wrong.
Line 1010:         for nic in nics:
Line 1011:             ifup(nic, options.get('bootproto') == 'dhcp' and not blockingDhcp)
Line 1012: 
Line 1013:     # Now we can ifup VLAN interface, because bond and nic already up

Line 1006
Line 1007
Line 1008
Line 1009
Line 1010
am I right that with this removed, we can drop the abomination which is nicSort?

it seems that only its own unittest is now using it.

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Antoni Segura Puimedon has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 2: (2 inline comments)

....................................................
File vdsm/configNetwork.py
Line 1005:     if bonding:
Line 1006:         ifup(bonding, bondBootproto == 'dhcp' and not blockingDhcp)
Line 1007:     else:
Line 1008:         # NICs must be activated in the same order of boot time
Line 1009:         # to expose the correct MAC address.
I was thinking about checking if zero or one, but since it is either a list of zero or one elements I liked more the for.

The comment I agree that should be removed.
Line 1010:         for nic in nics:
Line 1011:             ifup(nic, options.get('bootproto') == 'dhcp' and not blockingDhcp)
Line 1012: 
Line 1013:     # Now we can ifup VLAN interface, because bond and nic already up

Line 1006
Line 1007
Line 1008
Line 1009
Line 1010
I'll review that. it is quite possible that it can be dropped. I saw it being used by your more delicate rollback.

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 2: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 1006
Line 1007
Line 1008
Line 1009
Line 1010
yeah, I just noticed this myself, so I have to take my words back.

Only when someone makes _sortModifiedIfcfgs aware of the cfg type, and skip bond members, nicSort could be dropped.

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Meni Yakove has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 2: Verified

Check that bonds modes changed and slaves interfaces are up under /proc/net/bonding/bond0.
After every change/create bond all slaves was up and the bond was up.

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/410/ (1/2)

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/375/ (2/2)

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/375/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/410/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Remove redundant ifupping of bonded ifaces.

ifup-eth of initscripts, when ifupping a bond checks which are
its slaves and ifups them. Thus, removing this two ifup places
we avoid a big source of FAILED messages in our logs while
keeping all the functionality and correctness.

Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Signed-off-by: Antoni S. Puimedon 
---
M vdsm/configNetwork.py
1 file changed, 3 insertions(+), 9 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................

Patch Set 3: Verified; Looks good to me, approved

Copying Meni's V+1

Thanks! I hope we gain a couple of seconds!

--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: oVirt Jenkins CI Server