9:23 a.m.
Eduardo has uploaded a new change for review.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
[WIP] Towards a more (block) secure HSM.
Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
---
M vdsm/storage/hsm.py
M vdsm/storage/lvm.py
M vdsm/storage/sp.py
3 files changed, 25 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/2218/1
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
6:54 a.m.
Haim Ateya has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 1: Fails
- you broke _updateLvmConf
- spmStart fails on vgchange command trying to use lockingType=4
- please add support for createStorageDomain from non-SPM hosts
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
4:03 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/400/
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:03 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/400/ : ABORTED
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:42 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/189/ (1/3)
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:42 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1078/ (2/3)
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:42 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1043/ (3/3)
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:44 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 2: Fails; I would prefer that you didn't submit this
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1043/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1078/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/189/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:25 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1062/ (2/3)
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:25 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/208/ (3/3)
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:25 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1097/ (1/3)
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:33 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 3: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1062/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1097/ : ABORTED
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/208/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:41 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/416/ (3/3)
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:41 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1270/ (1/3)
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:41 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1305/ (2/3)
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:55 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1270/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1305/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/416/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:05 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2231/ (1/2)
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:05 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2170/ (2/2)
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:08 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2231/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2170/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11:07 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 6: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6045/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6832/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6938/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:45 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 7: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6322/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7212/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7105/ : UNSTABLE
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <haim.ateya(a)gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:25 a.m.
Ayal Baron has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 7:
(3 comments)
http://gerrit.ovirt.org/#/c/2218/7/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 310:
Line 311: def validateSPM(self, spUUID):
Line 312: pool = self.getPool(spUUID)
Line 313: if pool.spmRole != sp.SPM_ACQUIRED:
Line 314: lvm.setLvmROMD()
redundant
Line 315: raise se.SpmStatusError(spUUID)
Line 316:
Line 317: def validateNotSPM(self, spUUID):
Line 318: pool = self.getPool(spUUID)
Line 601: :raises: :exc:`storage_exception.TaskInProgress`
Line 602: if there are tasks running for this pool.
Line 603:
Line 604: """
Line 605: lvm.setLvmROMD()
should be in stopSpm inside sp
Line 606: vars.task.setDefaultException(se.SpmStopError(spUUID))
Line 607: vars.task.getExclusiveLock(STORAGE, spUUID)
Line 608:
Line 609: pool = self.getPool(spUUID)
http://gerrit.ovirt.org/#/c/2218/7/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 267:
Line 268: try:
Line 269: self.lver = int(oldlver) + 1
Line 270:
Line 271: blockSD.lvm.setLvmRWMD() # Do it later
1. do it later where? why?
Line 272:
Line 273: self._backend.setSpmStatus(self.lver, self.id,
Line 274: __securityOverride=True)
Line 275: self._maxHostID = maxHostID
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <haim.ateya(a)gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
8:06 a.m.
Yeela Kaplan has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 7:
(3 comments)
http://gerrit.ovirt.org/#/c/2218/7/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 310:
Line 311: def validateSPM(self, spUUID):
Line 312: pool = self.getPool(spUUID)
Line 313: if pool.spmRole != sp.SPM_ACQUIRED:
Line 314: lvm.setLvmROMD()
redundant
Done
Line 315: raise se.SpmStatusError(spUUID)
Line 316:
Line 317: def validateNotSPM(self, spUUID):
Line 318: pool = self.getPool(spUUID)
Line 601: :raises: :exc:`storage_exception.TaskInProgress`
Line 602: if there are tasks running for this pool.
Line 603:
Line 604: """
Line 605: lvm.setLvmROMD()
should be in stopSpm inside sp
Done
Line 606: vars.task.setDefaultException(se.SpmStopError(spUUID))
Line 607: vars.task.getExclusiveLock(STORAGE, spUUID)
Line 608:
Line 609: pool = self.getPool(spUUID)
http://gerrit.ovirt.org/#/c/2218/7/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 267:
Line 268: try:
Line 269: self.lver = int(oldlver) + 1
Line 270:
Line 271: blockSD.lvm.setLvmRWMD() # Do it later
1. do it later where? why?
I guess that the intention is to
where the next comment is, but it's irrelevant now so I'm removing it
Line 272:
Line 273: self._backend.setSpmStatus(self.lver, self.id,
Line 274: __securityOverride=True)
Line 275: self._maxHostID = maxHostID
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <haim.ateya(a)gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10:07 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 8: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6478/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7263/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7381/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <haim.ateya(a)gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:14 a.m.
New subject: Change in vdsm[master]: Towards a more (block) secure HSM.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Towards a more (block) secure HSM.
......................................................................
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6483/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7267/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7385/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <haim.ateya(a)gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:34 a.m.
New subject: Change in vdsm[master]: Towards a more (block) secure HSM.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Towards a more (block) secure HSM.
......................................................................
Patch Set 10: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6507/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7292/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7410/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <haim.ateya(a)gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:58 a.m.
New subject: Change in vdsm[master]: Towards a more (block) secure HSM.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Towards a more (block) secure HSM.
......................................................................
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6799/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7589/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7699/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <haim.ateya(a)gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:46 p.m.
New subject: Change in vdsm[master]: Towards a more (block) secure HSM.
Itamar Heim has posted comments on this change.
Change subject: Towards a more (block) secure HSM.
......................................................................
Patch Set 11:
ping
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)gmail.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)gmail.com>
Gerrit-Reviewer: Haim Ateya <haim.ateya(a)gmail.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:12 a.m.
New subject: Change in vdsm[master]: Towards a more (block) secure HSM.
Itamar Heim has abandoned this change.
Change subject: Towards a more (block) secure HSM.
......................................................................
Abandoned
no activity. please restore if/when still relevant.
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <haim.ateya(a)gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
3565
days inactive
4445
days old
vdsm-patches@lists.fedorahosted.org
28 comments
6 participants
participants (6)
-
abaron＠redhat.com -
ewarszaw＠redhat.com -
Haim Ateya -
iheim＠redhat.com -
Jenkins CI RO -
ykaplan＠redhat.com