11:05 a.m.
Yeela Kaplan has uploaded a new change for review.
Change subject: additional capsTests
......................................................................
additional capsTests
Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1
Signed-off-by: y kaplan <ykaplan(a)redhat.com>
---
M tests/Makefile.am
M tests/capsTests.py
A tests/route_info.out
M vdsm/caps.py
4 files changed, 25 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/4185/1
--
To view, visit http://gerrit.ovirt.org/4185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
6:07 a.m.
Gal Hammer has posted comments on this change.
Change subject: additional capsTests
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
2:45 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: additional capsTests
......................................................................
additional capsTests
Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1
Signed-off-by: y kaplan <ykaplan(a)redhat.com>
---
M tests/Makefile.am
M tests/capsTests.py
A tests/route_info.out
M vdsm/caps.py
4 files changed, 29 insertions(+), 6 deletions(-)
Approvals:
Yeela Kaplan: Verified
Gal Hammer: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
2:45 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: additional capsTests
......................................................................
Patch Set 5: Looks good to me, approved
Thanks!
--
To view, visit http://gerrit.ovirt.org/4185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
8:28 a.m.
Yeela Kaplan has posted comments on this change.
Change subject: additional capsTests
......................................................................
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/4185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
8:24 a.m.
Gal Hammer has posted comments on this change.
Change subject: additional capsTests
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
1:29 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: additional capsTests
......................................................................
Patch Set 4: Looks good to me, approved
awaiting verification...
--
To view, visit http://gerrit.ovirt.org/4185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
8:51 a.m.
Gal Hammer has posted comments on this change.
Change subject: additional capsTests
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
9:01 a.m.
Gal Hammer has posted comments on this change.
Change subject: additional capsTests
......................................................................
Patch Set 2: (2 inline comments)
Added some inline comments.
....................................................
Commit Message
Line 2: Author: y kaplan <ykaplan(a)redhat.com>
Please set your git's global config to your full name.
....................................................
File tests/capsTests.py
Line 66: expectedRes = "wlan0"
You should use a loop rather than duplicate the code.
values = { "10.201.129.37": "wlan0", "192.168.122.90":
"virbr0" }
for ip, name in values:
self.assertEqual(name, caps._getIfaceByIP(ip, "route_info.out"))
--
To view, visit http://gerrit.ovirt.org/4185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
6:35 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: additional capsTests
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File tests/capsTests.py
Line 62: for res, s in map(None, expectedRes, sign):
no zip() for me?
--
To view, visit http://gerrit.ovirt.org/4185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
3:16 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: additional capsTests
......................................................................
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
12:39 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: additional capsTests
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
thanks! only one very minor comment.
....................................................
File tests/route_info.out
Line 1: face Destination Gateway Flags RefCnt Use Metric Mask MTU Window IRTT
where's the leading I?
--
To view, visit http://gerrit.ovirt.org/4185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
4394
days inactive
4425
days old
vdsm-patches@lists.fedorahosted.org
11 comments
3 participants
participants (3)
-
Dan Kenigsberg -
ghammer＠redhat.com -
ykaplan＠redhat.com