Change in vdsm[ovirt-3.5]: tests: temporarily exclude few tests to restore CI

Hello Adam Litke, Ondřej Svoboda, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/46884

to review the following change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

tests: temporarily exclude few tests to restore CI

A few network tests require the TUN device, which is not available
under mock environments.

Furthermore, when run under the new CI infrastructure which leverages mock,
we can see this error:

======================================================================
ERROR: testGetBondingOptions (netinfoTests.TestNetinfo)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/run/tests/monkeypatch.py", line 133, in wrapper
    return f(*args, **kw)
  File "/tmp/run/tests/testValidation.py", line 105, in wrapper
    return f(*args, **kwargs)
  File "/tmp/run/tests/testValidation.py", line 145, in wrapper
    return f(*args, **kwargs)
  File "/tmp/run/tests/netinfoTests.py", line 290, in
testGetBondingOptions
    with open(netinfo.BONDING_MASTERS, 'w') as bonds:
IOError: [Errno 13] Permission denied: '/sys/class/net/bonding_masters'
-------------------- >> begin captured logging << --------------------
root: DEBUG: /sbin/modprobe bonding (cwd None)
root: DEBUG: FAILED: <err> = ''; <rc> = 1
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------

This happens if the system cannot load modules inside the chrooted
mock environments.

We temporarily NOSE_EXCLUDE away the problematic jobs in order to
restore CI automated tests. We will restore those tests ASAP once
fixed to run properly in mocked environments.

Change-Id: I1721a0e2fccb9f8fff216f866843fa1daf192185
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/45134
Reviewed-by: Ondřej Svoboda 
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/45264
Reviewed-by: Adam Litke 
---
M automation/check-patch.sh
1 file changed, 3 insertions(+), 9 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/46884/1

diff --git a/automation/check-patch.sh b/automation/check-patch.sh
index 065b6f4..51f7ee3 100755
--- a/automation/check-patch.sh
+++ b/automation/check-patch.sh
@@ -7,17 +7,11 @@
 #export NOSE_WITH_XUNIT=1

export NOSE_SKIP_STRESS_TESTS=1
-export NOSE_EXCLUDE=
+# this redefines 'ugly' but looks like NOSE_EXCLUDE works at test method level,
+# not at module neither at testcase level, so we have no choice but this.
+export NOSE_EXCLUDE=".*testGetBondingOptions.*|testMirroring.*|testToggleIngress|testException|testQdiscsOfDevice|testReplacePrio"
 # disable pep8 checks on unit test, since we have seperate job on it.
 export PEP8=$(which true)
-
-# really ugly and hopefully temporary fix
-# https://bugzilla.redhat.com/show_bug.cgi?id=1255142
-[[ -e /dev/net/tun ]] \
-|| {
-    [[ -e /dev/net ]] || mkdir /dev/net
-    mknod /dev/net/tun c 10 200
-}

sh -x autogen.sh --system
 make all

[e-mail] has posted comments on this change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

Patch Set 1: Verified-1

* Update tracker::IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

[e-mail] has posted comments on this change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

Patch Set 2:

* Update tracker::#1267851::OK
* Check Bug-Url::OK
* Check Public Bug::#1267851::OK, public bug
* Check Product::#1267851::OK, Correct classification oVirt
* Check TR::#1267851::ERROR, wrong target release for stable branch, --- should match ^3.[54321].*
* Check merged to previous::OK, change not open on any previous branch

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

Patch Set 2: Code-Review+1

[e-mail] has posted comments on this change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

Patch Set 3:

* Update tracker::#1267851::OK
* Check Bug-Url::OK
* Check Public Bug::#1267851::OK, public bug
* Check Product::#1267851::OK, Correct classification oVirt
* Check TR::#1267851::ERROR, wrong target release for stable branch, --- should match ^3.[54321].*
* Check merged to previous::OK, change not open on any previous branch

[e-mail] has posted comments on this change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

Patch Set 4:

* Update tracker::#1267851::OK
* Check Bug-Url::OK
* Check Public Bug::#1267851::OK, public bug
* Check Product::#1267851::OK, Correct classification oVirt
* Check TR::#1267851::ERROR, wrong target release for stable branch, --- should match ^3.[54321].*
* Check merged to previous::OK, change not open on any previous branch

[e-mail] has posted comments on this change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

Patch Set 5:

* Update tracker::#1267851::OK
* Check Bug-Url::OK
* Check Public Bug::#1267851::OK, public bug
* Check Product::#1267851::OK, Correct classification oVirt
* Check TR::#1267851::ERROR, wrong target release for stable branch, --- should match ^3.[54321].*
* Check merged to previous::OK, change not open on any previous branch

[e-mail] has posted comments on this change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

Patch Set 6:

* Update tracker::#1267851::OK
* Check Bug-Url::OK
* Check Public Bug::#1267851::OK, public bug
* Check Product::#1267851::OK, Correct classification oVirt
* Check TR::#1267851::ERROR, wrong target release for stable branch, --- should match ^3.[54321].*
* Check merged to previous::OK, change not open on any previous branch

Francesco Romani has posted comments on this change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

Patch Set 6: Continuous-Integration+1 Verified+1

automation works locally. Previous patches will make sure this doesn't fail.

[e-mail] has posted comments on this change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

Patch Set 7:

* Update tracker::#1267851::OK
* Check Bug-Url::OK
* Check Public Bug::#1267851::OK, public bug
* Check Product::#1267851::OK, Correct classification oVirt
* Check TR::#1267851::ERROR, wrong target release for stable branch, --- should match ^3.[54321].*
* Check merged to previous::OK, change not open on any previous branch

[e-mail] has posted comments on this change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

Patch Set 8:

* Update tracker::#1267851::OK
* Check Bug-Url::OK
* Check Public Bug::#1267851::OK, public bug
* Check Product::#1267851::OK, Correct classification oVirt
* Check TR::#1267851::ERROR, wrong target release for stable branch, --- should match ^3.[54321].*
* Check merged to previous::OK, change not open on any previous branch

[e-mail] has posted comments on this change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

Patch Set 9:

* Update tracker::#1267851::OK
* Check Bug-Url::OK
* Check Public Bug::#1267851::OK, public bug
* Check Product::#1267851::OK, Correct classification oVirt
* Check TR::#1267851::ERROR, wrong target release for stable branch, --- should match ^3.[54321].*
* Check merged to previous::OK, change not open on any previous branch

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

Patch Set 9: Code-Review-1

This patch was wrong on master. If you want to backport it, get also the patch that fixed it on master.

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

Patch Set 9:

Francesco, you should backport this instead:
https://gerrit.ovirt.org/46641

[e-mail] has posted comments on this change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

Patch Set 10:

* Update tracker::#1267851::OK
* Check Bug-Url::OK
* Check Public Bug::#1267851::OK, public bug
* Check Product::#1267851::OK, Correct classification oVirt
* Check TM::#1267851::OK, correct target milestone ovirt-3.5.6
* Check merged to previous::OK, change not open on any previous branch

Francesco Romani has abandoned this change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

Abandoned

abandoned as per suggestions

[e-mail] has posted comments on this change.

Change subject: tests: temporarily exclude few tests to restore CI
......................................................................

Patch Set 10:

* Update tracker::#1267851::OK