Nir Soffer has posted comments on this change.
Change subject: lib: vdscli: switch to the new devel_warn helper
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/62211/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Line 139:
Line 140:
Line 141: devel_warn
Line 142: "vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please use
"
Line 143: "vdsm.jsonrpcvdscli")
We don't need this warning, adding a comment that the module is deprecated is good
enough.
Line 144:
Line 145:
Line 146: if __name__ == '__main__':
Line 147: print('connecting to %s:%s ssl %s ts %s' % (
--
To view, visit
https://gerrit.ovirt.org/62211
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1189097826e79290cb996657ccf34a7c2b611ee0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes