Francesco Romani has uploaded a new change for review.
Change subject: vm: do not call before_vm_create in dehibernation ......................................................................
vm: do not call before_vm_create in dehibernation
For reasons unknown, VDSM calls the before_vm_create hook also in the dehibernation path.
This is wasteful and useless at best, and most likely misleading and wrong, because VDSM logs the XML it produced, which is *not* what is gonna be used in the dehibernation path. The hook is fed with phony data, and the output of the hook is discarded.
This patch dispel the lie and avoid to call the before_vm_create hook in the dehibernation path.
Change-Id: I4c1377346b1ae63a1feb15e1458b5141c255c849 X-Backport-To: 3.6 Signed-off-by: Francesco Romani fromani@redhat.com --- M vdsm/virt/vm.py 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/45074/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index c54853a..b77b9df 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -1887,8 +1887,6 @@ hooks.before_vm_dehibernate(srcDomXML, self.conf, {'FROM_SNAPSHOT': str(fromSnapshot)})
- # TODO: this silliness is only to preserve the old behaviour - hooks.before_vm_start(self._buildDomainXML(), self.conf) # TODO: this is debug information. For 3.6.x we still need to # see the XML even with 'info' as default level. self.log.info(srcDomXML)
automation@ovirt.org has posted comments on this change.
Change subject: vm: do not call before_vm_create in dehibernation ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Francesco Romani has posted comments on this change.
Change subject: vm: do not call before_vm_create in dehibernation ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45074/1//COMMIT_MSG Commit Message:
Line 17: This patch dispel the lie and avoid to call the before_vm_create Line 18: hook in the dehibernation path. Line 19: Line 20: Change-Id: I4c1377346b1ae63a1feb15e1458b5141c255c849 Line 21: X-Backport-To: 3.6 drop leading X-
automation@ovirt.org has posted comments on this change.
Change subject: vm: do not call before_vm_start in dehibernation ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Dan Kenigsberg has posted comments on this change.
Change subject: vm: do not call before_vm_start in dehibernation ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45074/1//COMMIT_MSG Commit Message:
Line 14: gonna be used in the dehibernation path. The hook is fed with Line 15: phony data, and the output of the hook is discarded. Line 16: Line 17: This patch dispel the lie and avoid to call the before_vm_create Line 18: hook in the dehibernation path. this removal is problematic. We may have hooks that depend on this call. vmfex_dev may be one of them. We should take a closer look. Line 19: Line 20: Change-Id: I4c1377346b1ae63a1feb15e1458b5141c255c849 Line 21: X-Backport-To: 3.6
Francesco Romani has posted comments on this change.
Change subject: vm: do not call before_vm_start in dehibernation ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45074/1//COMMIT_MSG Commit Message:
Line 14: gonna be used in the dehibernation path. The hook is fed with Line 15: phony data, and the output of the hook is discarded. Line 16: Line 17: This patch dispel the lie and avoid to call the before_vm_create Line 18: hook in the dehibernation path.
this removal is problematic. We may have hooks that depend on this call. vm
Good point. Will start checking myself and write down a list.
Btw, since the XML used as input is wrong, I wonder how the hooks which depend on that actually work. Line 19: Line 20: Change-Id: I4c1377346b1ae63a1feb15e1458b5141c255c849 Line 21: X-Backport-To: 3.6
gerrit-hooks has posted comments on this change.
Change subject: vm: do not call before_vm_start in dehibernation ......................................................................
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: vm: do not call before_vm_start in dehibernation ......................................................................
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: vm: do not call before_vm_start in dehibernation ......................................................................
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
vdsm-patches@lists.fedorahosted.org
-
automation＠ovirt.org -
Dan Kenigsberg -
fromani＠redhat.com