Change in vdsm[master]: Related to BZ#815359 - Improve log on qemu-convert error.

Eduardo has uploaded a new change for review.

Change subject: Related to BZ#815359 - Improve log on qemu-convert error.
......................................................................

Related to BZ#815359 - Improve log on qemu-convert error.

Change-Id: I7e9e139f3254953577cfebe048ea89a2ababf2a6
Signed-off-by: Eduardo <ewarszaw(a)redhat.com&gt;
---
M vdsm/storage/image.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/76/7476/1

diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index 74ee79e..d004046 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -1020,6 +1020,8 @@
             srcVolParams['volFormat'], volParams['volFormat'],
vars.task.aborting,
             size=volParams['apparentsize'], dstvolType=newVol.getType())
         if rc:
+            self.log.error("qemu-img convert failed: rc=%s, out=%s, err=%s",
+                            rc, out, err)
             raise se.MergeSnapshotsError(newUUID)
 
         newVol.teardown(sdUUID=newVol.sdUUID, volUUID=newVol.volUUID)


--
To view, visit http://gerrit.ovirt.org/7476
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e9e139f3254953577cfebe048ea89a2ababf2a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Related to BZ#815359 - Improve log on qemu-convert error.
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/7476
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e9e139f3254953577cfebe048ea89a2ababf2a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Related to BZ#815359 - Improve log on qemu-convert error.
......................................................................


Related to BZ#815359 - Improve log on qemu-convert error.

Change-Id: I7e9e139f3254953577cfebe048ea89a2ababf2a6
Signed-off-by: Eduardo <ewarszaw(a)redhat.com&gt;
---
M vdsm/storage/image.py
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Ayal Baron: Looks good to me, approved
  Yeela Kaplan: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified


--
To view, visit http://gerrit.ovirt.org/7476
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7e9e139f3254953577cfebe048ea89a2ababf2a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Ayal Baron has posted comments on this change.

Change subject: Related to BZ#815359 - Improve log on qemu-convert error.
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/7476
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e9e139f3254953577cfebe048ea89a2ababf2a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Yeela Kaplan has posted comments on this change.

Change subject: Related to BZ#815359 - Improve log on qemu-convert error.
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7476
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e9e139f3254953577cfebe048ea89a2ababf2a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Related to BZ#815359 - Improve log on qemu-convert error.
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/672/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/7476
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e9e139f3254953577cfebe048ea89a2ababf2a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server