Change in vdsm[master]: Passing "$*" to shell func with quotation marks passes all v...

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Passing "$*" to shell func with quotation marks passes all vars in one
......................................................................

Passing "$*" to shell func with quotation marks passes all vars in one

Instead of passing the variables as passed to test_conflicting_conf
to the specific test func

Change-Id: Iee8d5f3e9c01bd879a1e41159fa798eefd2c51ca
Signed-off-by: Yaniv Bronhaim 
---
M lib/vdsm/tool/libvirt_configure.sh.in
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/24580/1

diff --git a/lib/vdsm/tool/libvirt_configure.sh.in b/lib/vdsm/tool/libvirt_configure.sh.in
index 89f1534..49e0e1e 100755
--- a/lib/vdsm/tool/libvirt_configure.sh.in
+++ b/lib/vdsm/tool/libvirt_configure.sh.in
@@ -52,7 +52,7 @@
 }

test_conflicting_conf() {
-    test_ssl_conflict_conf "$*"
+    test_ssl_conflict_conf $*
     # add here additional conf checks
 }

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Passing "$*" to shell func with quotation marks passes all vars in one
......................................................................

Patch Set 1: Verified-1

Build Failed

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7282/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6384/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7168/ : SUCCESS

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Passing "$*" to shell func with quotation marks passes all vars in one
......................................................................

Patch Set 2: Code-Review+1

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Passing "$*" to shell func with quotation marks passes all vars in one
......................................................................

Patch Set 2: Verified-1

Build Failed

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7284/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6385/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7169/ : SUCCESS

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Passing "$*" to shell func with quotation marks passes all vars in one
......................................................................

Patch Set 2: Verified+1 Code-Review+2

In commit 9f57910 I've fell in the oldest pit: verified one code, but pushed an older version.

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Passing "$*" to shell func with quotation marks passes all vars in one
......................................................................

Passing "$*" to shell func with quotation marks passes all vars in one

Instead of passing the variables as passed to test_conflicting_conf
to the specific test func

Change-Id: Iee8d5f3e9c01bd879a1e41159fa798eefd2c51ca
Signed-off-by: Yaniv Bronhaim 
Reviewed-on: http://gerrit.ovirt.org/24580
Reviewed-by: Dan Kenigsberg 
Tested-by: Dan Kenigsberg 
---
M lib/vdsm/tool/libvirt_configure.sh.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved