Haim Ateya has uploaded a new change for review.
Change subject: BZ#787594 - set securityOverride=True for unsecured function trying to write to metadata in forceFreeSpm flow ......................................................................
BZ#787594 - set securityOverride=True for unsecured function trying to write to metadata in forceFreeSpm flow
Change-Id: I6c438f0ef4029373f1b118e0b39440478814abfd --- M vdsm/storage/sp.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/1642/1 -- To view, visit http://gerrit.ovirt.org/1642 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I6c438f0ef4029373f1b118e0b39440478814abfd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Haim Ateya hateya@redhat.com
Haim Ateya has posted comments on this change.
Change subject: BZ#787594 - set securityOverride=True for unsecured function trying to write to metadata in forceFreeSpm flow ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/1642 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6c438f0ef4029373f1b118e0b39440478814abfd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#787594 - set securityOverride=True for unsecured function trying to write to metadata in forceFreeSpm flow ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
two minor comments + you do not need to open a bug for upstream fixes.
.................................................... Commit Message Line 7: BZ#787594 - set securityOverride=True for unsecured function trying to subject line must be shorter.
enable fenceSpmStorage on hsm nodes
now explain WHY not HOW
.................................................... File vdsm/storage/sp.py Line 148: self.setMetaParams({PMDK_SPM_ID: -1, PMDK_LVER: -1}, __securityOverride=True) keep line shorter than 80, please.
-- To view, visit http://gerrit.ovirt.org/1642 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6c438f0ef4029373f1b118e0b39440478814abfd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com
Haim Ateya has posted comments on this change.
Change subject: BZ#787594 - Enable fenceSpmStorage on hsm nodes ......................................................................
Patch Set 3: Verified
-- To view, visit http://gerrit.ovirt.org/1642 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6c438f0ef4029373f1b118e0b39440478814abfd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#787594 - Enable fenceSpmStorage on hsm nodes ......................................................................
Patch Set 3: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1642 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6c438f0ef4029373f1b118e0b39440478814abfd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#787594 - Enable fenceSpmStorage on hsm nodes ......................................................................
BZ#787594 - Enable fenceSpmStorage on hsm nodes
Change-Id: I6c438f0ef4029373f1b118e0b39440478814abfd --- M vdsm/storage/sp.py 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: Haim Ateya: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1642 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I6c438f0ef4029373f1b118e0b39440478814abfd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com
vdsm-patches@lists.fedorahosted.org