Change in vdsm[master]: added support for mirror promisc mode

Shahar Havivi has uploaded a new change for review.

Change subject: added support for mirror promisc mode
......................................................................

added support for mirror promisc mode

let ability to VM to monitor (mirror) all other VMs in the same host by
specific network (bridge)

Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
---
M configure.ac
M vdsm/libvirtvm.py
2 files changed, 123 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/956/1
--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Shahar Havivi

Saggi Mizrahi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(7 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 1480:     def _releasePromiscNetwork(self, networkName):
This whole function looks like it needs to be in it's own module

Line 1489:         command = ['/sbin/tc', 'qdisc', 'del', 'dev', networkName, 'root']
Why did you put the path in constants if your not going ot use it?
Anyway please thinly wrap TC phonically in a file (tc.py?) and then use the methods everywhere else.

Line 1490:         retcode, out, err = utils.execCmd(command, sudo=True, raw=True)
Use supervdsm for root operations

Line 1492:             e = errmsg % (' '.join(command), err)
use subprocess.list2cmdline()

Line 1493:             self.log.error(e)
consider using exc_info=True

Line 1502:         command = ['/sbin/ifconfig', networkName, '-promisc']
Please do the same for ifconfig

Line 1508:     def _capturePromiscNetwork(self, networkName, ifaceName, mode):
This one might join the other one in the aforementioned module

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Saggi Mizrahi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

Please try and have all the cmd parsing stuff in separate modules wrapping the operations and then use the actual logic in code. Mixing everything makes reading, understanding, and debugging much harder.

....................................................
File vdsm/supervdsmServer.py
Line 187:         this command will run:
When commenting don't say what you do say what you mean to do.

Line 193:         command = [EXT_TC, 'qdisc', 'del', 'dev', networkName, 'root']
You already have tc.py, create a wrapper there.
Creating wrapper functions in tc will not only make the code easier to understand but will also make this whole function 4 lines long

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 2: (1 inline comment)

....................................................
File vdsm/supervdsmServer.py
Line 193:         command = [EXT_TC, 'qdisc', 'del', 'dev', networkName, 'root']
what do you mean by wrapper?

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 3: (1 inline comment)

....................................................
File vdsm/tc.py
Line 23: class MirrorPromisc():
I'm not sure if this class deserves a new module. If it solves something strictly related to a vm definition (as it looks since it's checking the 'promisc' attribute in the nics objects) then it belongs to libvirtvm. If instead it's something more generic and networking related then it belongs configNetwork.

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 3: (1 inline comment)

....................................................
File vdsm/tc.py
Line 23: class MirrorPromisc():
well I didn't thought so as well, but Sagi ask me to add a class to TC...

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Saggi Mizrahi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/tc.py
Line 23: class MirrorPromisc():
You misunderstood.

You need tc.py which is a thin wrapper around the tc tool

tc.py
--------
def qdisc_add(networkname):
                command = [EXT_TC, 'qdisc', 'add', 'dev', networkName, 'ingress']
            retcode, out, err = storage.misc.execCmd(command, raw=True, sudo=False)
            if retcode != 0:
                e = errmsg % (list2cmdline(command), err)
                raise Exception(e)

def qdisc_replace(networkName, parent='root'):
  .....

I think you got the point
---------------

Now that you have a thin wrapper around tc in tc.py

create a method called set\unsetPromisc(nics) somewhere else (not in the thin wrapper as this uses more then 1 thinly wrapped calls

Have them accessible through supervdsm

use them in your code.

The class is overkill in any case as there is no reason to hold the state.

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 3: (1 inline comment)

....................................................
File vdsm/tc.py
Line 23: class MirrorPromisc():
I don't agree that we need to wrap each call of tc, 
the superVdsm.setMirrorPromisc is doing a set of actions in order to set "mirror" mode, there is an inline mode as well that the qdisc_add will be different....

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 5: Verified

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 6: Verified

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 7: Verified

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 8: Verified

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 8: I would prefer that you didn't submit this

(4 inline comments)

....................................................
File vdsm/supervdsmServer.py
Line 186:         Release captured  mirror network traffic from network bridge
this function simple unsets the promisc mode which setMirrorPromisc() has set? then unsetMirrorPromisc would be a clearer name.

Line 197:             raise Exception(e)
raising a specific exception is better style.

and I agree with Saggi that this handling of TC command line would look better in a function of its own.

....................................................
File vdsm/tc.py
Line 2: # Copyright 2009-2011 Red Hat, Inc.
actually, this is new in 2012

Line 40:             if hasattr(nic, 'promisc'):
a nic is connected only to a single host network. so why promisc has a list of them? It should've been True/False.

anyway, I do not understand the motivation of this class, and I am not sure it warrants its own module.

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Peter V. Saveliev has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 8: Verified; I would prefer that you didn't submit this

(2 inline comments)

not breaks the vdsm but I'm not sure I'd like to see it this way

....................................................
File vdsm/supervdsmServer.py
Line 255:         devId = out[11:16]
are you sure it is the safe way to extract the device id?

....................................................
File vdsm/tc.py
Line 38:         '''
with «red,blue:miror» we'll get here ("red", "blue:mirror"), is it ok?

what exactly we expect here, just interface names separated with commas? what the «:mirror» stands for?

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 8: (2 inline comments)

....................................................
File vdsm/supervdsmServer.py
Line 255:         devId = out[11:16]
I don't know other way to extract the dynamic id that tc give you

....................................................
File vdsm/tc.py
Line 38:         '''
mirror is the mode of promisc mode, there is inline as well (currently not implemented)

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 15: Verified

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 15: I would prefer that you didn't submit this

(3 inline comments)

....................................................
Commit Message
Line 10: specific network (bridge)
please mention open issue: there is (current) no protection agains mirroring a network twice. unsettingMirred will clear both mirroring.

....................................................
File vdsm/libvirtvm.py
Line 1208:                 for network in nic.promisc.split(',').iterkeys():
I'd prefer the API to be a list, not a coma-separated string.

Line 1894:         for nic in self._devices[vm.NIC_DEVICES]:
could you shove this into releaseVm ?

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 15: (3 inline comments)

....................................................
Commit Message
Line 10: specific network (bridge)
Done

....................................................
File vdsm/libvirtvm.py
Line 1208:                 for network in nic.promisc.split(',').iterkeys():
Done

Line 1894:         for nic in self._devices[vm.NIC_DEVICES]:
Done

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 16: Verified

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 16: (2 inline comments)

minor comment-related comments.

....................................................
File vdsm/supervdsmServer.py
Line 188:         :param networkName: networkName bridge name to capture the traffic from
bridge != network. I suggest this is the network name.

....................................................
File vdsm/tc.py
Line 2: # Copyright 2009-2011 Red Hat, Inc.
2012!

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 16: (2 inline comments)

....................................................
File vdsm/supervdsmServer.py
Line 188:         :param networkName: networkName bridge name to capture the traffic from
Done

....................................................
File vdsm/tc.py
Line 2: # Copyright 2009-2011 Red Hat, Inc.
Done

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 17: Verified

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

Peter V. Saveliev has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 17: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: added support for mirror promisc mode
......................................................................

Patch Set 18: Verified; Looks good to me, approved

nasty rebase done. Sorry for letting your code rot for a month :-(

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: added support for mirror promisc mode
......................................................................

added support for mirror promisc mode

let ability to VM to monitor (mirror) all other VMs in the same host by
specific network (bridge)

Currently there is no protection agains mirroring a network twice,
unsetting mirror network will clear both mirroring (on the same network).

Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
---
M configure.ac
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/constants.py.in
M vdsm/libvirtvm.py
M vdsm/supervdsmServer.py
A vdsm/tc.py
7 files changed, 126 insertions(+), 0 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Peter V. Saveliev 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Shahar Havivi