Change in vdsm[ovirt-4.0]: vm: rename statsAge parameter

Hello Dan Kenigsberg, Milan Zamazal, Martin Polednik,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/65813

to review the following change.

Change subject: vm: rename statsAge parameter
......................................................................

vm: rename statsAge parameter

rename `statsAge' to `stats_age'.
Now it is pep8 friendlier, and it is easier to follow the code flow:
it is now possible to follow this flow end to end using
'git grep stats_age'.

It used to be called `statsAge' in camelCase only for legacy reasons.

Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc
Backport-To: 4.0
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1382578
Bug-Url: https://bugzilla.redhat.com/1382583
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/65508
Reviewed-by: Martin Polednik 
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal 
Reviewed-by: Dan Kenigsberg 
---
M vdsm/virt/vm.py
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/65813/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 5659ac5..07be2e6 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4834,18 +4834,18 @@
                       'running' if self._guestCpuRunning else 'stopped',
                       reason)

-    def _setUnresponsiveIfTimeout(self, stats, statsAge):
+    def _setUnresponsiveIfTimeout(self, stats, stats_age):
         if self.isMigrating():
             return
         # we don't care about decimals here
-        if statsAge < config.getint('vars', 'vm_command_timeout'):
+        if stats_age < config.getint('vars', 'vm_command_timeout'):
             return
         if stats['monitorResponse'] == '-1':
             return

self.log.warning('monitor became unresponsive'
                          ' (command timeout, age=%s)',
-                         statsAge)
+                         stats_age)
         stats['monitorResponse'] = '-1'

def updateNumaInfo(self):

gerrit-hooks has posted comments on this change.

Change subject: vm: rename statsAge parameter
......................................................................

Patch Set 1:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check merged to previous::OK,         change not open on any previous branch

Milan Zamazal has posted comments on this change.

Change subject: vm: rename statsAge parameter
......................................................................

Patch Set 1: Code-Review+1

[Martin Polednik]

Martin Polednik has posted comments on this change.

Change subject: vm: rename statsAge parameter
......................................................................

Patch Set 1: Code-Review+1

Francesco Romani has posted comments on this change.

Change subject: vm: rename statsAge parameter
......................................................................

Patch Set 1: Verified+1

verified on branch, same way as master

Francesco Romani has posted comments on this change.

Change subject: vm: rename statsAge parameter
......................................................................

Patch Set 1: Code-Review+2

Francesco Romani has submitted this change and it was merged.

Change subject: vm: rename statsAge parameter
......................................................................

vm: rename statsAge parameter

rename `statsAge' to `stats_age'.
Now it is pep8 friendlier, and it is easier to follow the code flow:
it is now possible to follow this flow end to end using
'git grep stats_age'.

It used to be called `statsAge' in camelCase only for legacy reasons.

Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc
Backport-To: 4.0
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1382578
Bug-Url: https://bugzilla.redhat.com/1382583
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/65508
Reviewed-by: Martin Polednik 
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/65813
---
M vdsm/virt/vm.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified; Looks good to me, approved
  Martin Polednik: Looks good to me, but someone else must approve
  Milan Zamazal: Looks good to me, but someone else must approve

gerrit-hooks has posted comments on this change.

Change subject: vm: rename statsAge parameter
......................................................................

Patch Set 2:

* update_tracker: OK
* Set MODIFIED::bug 1382578::::#1382578::::OK, already on MODIFIED
* Set MODIFIED::bug 1382578::::bug 1382583::::#1382583::SKIPPED, tm_suffix '' does not match branch_suffix '4.0'.