From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tool: clear networks configured by oVirt
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/79495/1/lib/vdsm/tool/network.py
File lib/vdsm/tool/network.py:
Line 121: networks_request[net] = {'remove': True}
Line 122: net_api.setupNetworks(networks_request, {}, {'connectivityCheck':
False})
Line 123:
Line 124:
Line 125: def _remove_dummy_network():
this monstrosity is added in lib/vdsm/tool/dummybr.py. it is not a vdsm network, only a
means to persist the dummy bridge.
Please add the bridge removal to dummybr.py (possibly in a separate patch)
Line 126: if
os.path.exists('/sys/class/net/{}'.format(net_api.DUMMY_BRIDGE)):
Line 127: commands.execCmd([constants.EXT_BRCTL, 'delbr',
net_api.DUMMY_BRIDGE])
Line 128:
Line 129: dummy_network = _get_libvirt_network_by_name(net_api.DUMMY_BRIDGE)
--
To view, visit
https://gerrit.ovirt.org/79495
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63702da4dd1c5a0328797f524734813ef251bdb6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes