From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Report downtime after a post-copy migration
......................................................................
virt: Report downtime after a post-copy migration
There are two migration downtime length values provided by libvirt after
a completed migration: `downtime' and `downtime_net'. Ideally,
`downtime' provides the complete downtime length, but only under the
assumption that the clocks on the hosts are perfectly synchronized. If
they are not, the value may be screwed by the clock differences.
For this reason, we report `downtime_net' for pre-copy migrations, which
includes only the time needed to transfer the data (and not other
overheads), but is correct even when the clocks are not perfectly
synchronized.
`downtime_net' is not reported for post-copy migrations as it is always
zero. So only `downtime' can be reported for post-copy migrations,
regardless of the potential problem with the clocks.
Engine and other tools reporting the downtime must take into account the
differences of the downtime value in pre-copy and post-copy.
Change-Id: I5f34e1ff577db325cc976431b3570f91833ff815
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
Bug-Url:
https://bugzilla.redhat.com/1354343
---
M lib/vdsm/libvirtconnection.py
M vdsm/clientIF.py
M vdsm/virt/vm.py
3 files changed, 18 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit
https://gerrit.ovirt.org/64144
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f34e1ff577db325cc976431b3570f91833ff815
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>