Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: gitignore: Ingore vdsm-lvm.rule.tpl ......................................................................
gitignore: Ingore vdsm-lvm.rule.tpl
In a previous commit I forgot to add this new template to the ignore list, which breaks the build. I will be punished for this.
Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: http://gerrit.ovirt.org/33630 Reviewed-by: Dan Kenigsberg danken@redhat.com --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/33634/1
diff --git a/.gitignore b/.gitignore index efb99aa..d1e919b 100644 --- a/.gitignore +++ b/.gitignore @@ -58,6 +58,7 @@ vdsm/storage/protect/safelease vdsm/storage/lvm.env vdsm/storage/vdsm-lvm.rules +vdsm/storage/vdsm-lvm.rules.tpl vdsm/sudoers.vdsm vdsm/svdsm.logger.conf vdsm/vdscli.py
Nir Soffer has posted comments on this change.
Change subject: gitignore: Ingore vdsm-lvm.rule.tpl ......................................................................
Patch Set 1: Verified+1
Yea, there is no bug url, but it fixes the build (first check in make check fails without it).
Dan Kenigsberg has posted comments on this change.
Change subject: gitignore: Ingore vdsm-lvm.rule.tpl ......................................................................
Patch Set 1: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gitignore: Ingore vdsm-lvm.rule.tpl ......................................................................
gitignore: Ingore vdsm-lvm.rule.tpl
In a previous commit I forgot to add this new template to the ignore list, which breaks the build. I will be punished for this.
Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: http://gerrit.ovirt.org/33630 Reviewed-by: Dan Kenigsberg danken@redhat.com Reviewed-on: http://gerrit.ovirt.org/33634 --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gitignore: Ingore vdsm-lvm.rule.tpl ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/30/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/26/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/25/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/30/ : SUCCESS
vdsm-patches@lists.fedorahosted.org