From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: api: adding context for api calls ......................................................................
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/75335/8//COMMIT_MSG Commit Message:
Line 11: header and it is passed around in vdsm using threadlocal. Line 12: Line 13: The context that we pass consists of: Line 14: - flow_id - uniquely identifies flow Line 15: - client_host - host from where specific verb was called fqdn or ip address? of the source? how local request are presented (localhost:54321)? how backward compatibility is handled when the context part is missing also should be mentioned here Line 16: - client_port - which port was used to call the verb Line 17: Line 18: Line 19: Bug-Url: https://bugzilla.redhat.com/1112120
https://gerrit.ovirt.org/#/c/75335/8/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py:
Line 62: Line 63: class Headers(object): Line 64: CONTENT_LENGTH = "content-length" Line 65: CONTENT_TYPE = "content-type" Line 66: FLOW_ID = "ovirtCorrelationId" why not ovirt-correlation-id as the rest of the headers? Line 67: SUBSCRIPTION = "subscription" Line 68: RECEIPT = "receipt" Line 69: RECEIPT_ID = "receipt-id" Line 70: DESTINATION = "destination"
vdsm-patches@lists.fedorahosted.org