Change in vdsm[master]: Make namespace registring more efficient

Saggi Mizrahi has uploaded a new change for review.

Change subject: Make namespace registring more efficient
......................................................................

Make namespace registring more efficient

Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
---
M vdsm/storage/resourceManager.py
1 file changed, 7 insertions(+), 4 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/673/1
--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

Adam Litke has posted comments on this change.

Change subject: Make namespace registring more efficient
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/resourceManager.py
Line 373:             if (namespace in self._namespaces) and not force:
I think you want to drop the 'and not force' here.

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Make namespace registring more efficient
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/resourceManager.py
Line 373:             if (namespace in self._namespaces) and not force:
yes, he definitely want :)

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Igor Lvovsky

Eduardo has posted comments on this change.

Change subject: Make namespace registring more efficient
......................................................................

Patch Set 1: I would prefer that you didn't submit this

See comments.

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky

Ayal Baron has posted comments on this change.

Change subject: Make namespace registring more efficient
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

On the way also change commit message and also explain *why* you're doing this change, i.e. why it is correct -
"currently we never remove entries from the domain namespace so there is no race between checking for existence of the entry and removal.  Performing the check outside of the lock improves performance significantly and avoids being locked out by WHATEVER when the namespace is already there"

....................................................
Commit Message
Line 7: Make namespace registring more efficient
s/registring/registeration/

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: Make namespace registering more efficient

Ayal Baron has posted comments on this change.

Change subject: Make namespace registering more efficient
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Make namespace registering more efficient

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Make namespace registering more efficient
......................................................................

Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Make namespace registering more efficient

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Make namespace registering more efficient
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Make namespace registering more efficient

Ayal Baron has posted comments on this change.

Change subject: Make namespace registering more efficient
......................................................................

Patch Set 4: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/storage/resourceManager.py
Line 370:                 raise ValueError("Namespace '%s' already exists." % namespace)
In block SD where registerNamespace is called it does not distinguish between illegat namespace and namespace already exists, I wonder if we shouldn't throw different exceptions and catch only this one at the upper level (and not just any exception)

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Make namespace registering more efficient

Ayal Baron has posted comments on this change.

Change subject: Make namespace registering more efficient
......................................................................

Patch Set 4:

Please note my comment though (should probably be a separate patch as it is nothing new)

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Make namespace registering more efficient

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Make namespace registering more efficient
......................................................................

Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Make namespace registering more efficient

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Make namespace registering more efficient
......................................................................

Patch Set 4: I would prefer that you didn't submit this

Looks good to me, approved. Saggi, please get someone to verify this, and push it.

but be a sport and mention BZ#769502 in commit message (here and the rest of the branch).

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Make namespace registering more efficient

Saggi Mizrahi has posted comments on this change.

Change subject: Make namespace registering more efficient
......................................................................

Patch Set 4: (1 inline comment)

....................................................
File vdsm/storage/resourceManager.py
Line 370:                 raise ValueError("Namespace '%s' already exists." % namespace)
Your comment is unrelated, I'm keeping old behavior.

You should send the patch yourself, send a FIXME patch or just hope that I'll fix it eventually.

But don't exert yourself I'll do it in a *different patch* when I send the batch again.

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Make namespace registering more efficient

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Make namespace registering more efficient
......................................................................

Patch Set 5: I would prefer that you didn't submit this

please mention BZ#769502 in comment

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: BZ#769502 - Make namespace registering more efficient

Ayal Baron has posted comments on this change.

Change subject: BZ#769502 - Make namespace registering more efficient
......................................................................

Patch Set 6: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: BZ#769502 - Make namespace registering more efficient

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: BZ#769502 - Make namespace registering more efficient
......................................................................

Patch Set 6: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: BZ#769502 - Make namespace registering more efficient

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#769502 - Make namespace registering more efficient
......................................................................

Patch Set 6: Verified

Verified by Saggi

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: BZ#769502 - Make namespace registering more efficient

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#769502 - Make namespace registering more efficient
......................................................................

BZ#769502 - Make namespace registering more efficient

Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
---
M vdsm/storage/resourceManager.py
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Ayal Baron: Looks good to me, approved
  Dan Kenigsberg: Verified
  Igor Lvovsky: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6cc424984816bf578ff2860bb3276c7cd7fa894a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi