[NEW PATCH] BZ#734136 - Stricter partition detection (via gerrit-bot)

New patch submitted by Saggi Mizrahi (smizrahi(a)redhat.com)

You can review this change at: http://gerrit.usersys.redhat.com/866

commit 8a883f5629c356e739ee0690a90f13db71c156a4
Author: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Date:   Tue Aug 30 11:41:34 2011 +0300

    BZ#734136 - Stricter partition detection
    
    Change-Id: Ibc242c7a3810efbc89083d0f0ea6fb193a63e331

diff --git a/vdsm/storage/devicemapper.py b/vdsm/storage/devicemapper.py
index 08cd533..8000928 100644
--- a/vdsm/storage/devicemapper.py
+++ b/vdsm/storage/devicemapper.py
@@ -29,6 +29,8 @@ from constants import EXT_DMSETUP
 
 DMPATH_FORMAT = "/dev/mapper/%s"
 
+DM_PREFIX_PARTITION = "Part"
+
 def getDmId(deviceMultipathName):
     devlinkPath = DMPATH_FORMAT % deviceMultipathName
     try:
@@ -99,8 +101,18 @@ def isBlockDevice(devName):
         return False
 
 def isPartitioned(devName):
-    devName = resolveDevName(devName)
-    return (len(getHolders(devName)) > 0)
+    dmName = resolveDevName(devName)
+    #Sometimes partitions are not managed by device mapper
+    possiblePartPath = os.path.join("/sys/block/", devName, devName +
"1")
+    if os.path.exists(possiblePartPath):
+            return True
+
+    mpathName = getDevName(dmName)
+    for holder in getHolders(dmName):
+        if getDevName(holder).startswith(mpathName):
+            return True
+
+    return False
 
 def getAllSlaves():
     deps = {}

Change in vdsm[master]: BZ#734136 - Stricter partition detection

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#734136 - Stricter partition detection
......................................................................


BZ#734136 - Stricter partition detection

Change-Id: Ibc242c7a3810efbc89083d0f0ea6fb193a63e331
---
M vdsm/storage/devicemapper.py
1 file changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Igor Lvovsky: Looks good to me, but someone else must approve
  David Naori: Verified
  Ayal Baron: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.usersys.redhat.com/866
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc242c7a3810efbc89083d0f0ea6fb193a63e331
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com&gt;

Change in vdsm[master]: BZ#734136 - Stricter partition detection

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#734136 - Stricter partition detection
......................................................................


Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.usersys.redhat.com/866
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc242c7a3810efbc89083d0f0ea6fb193a63e331
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com&gt;

Change in vdsm[master]: BZ#734136 - Stricter partition detection

[David Naori]

David Naori has posted comments on this change.

Change subject: BZ#734136 - Stricter partition detection
......................................................................


Patch Set 3: Verified

--
To view, visit http://gerrit.usersys.redhat.com/866
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc242c7a3810efbc89083d0f0ea6fb193a63e331
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com&gt;

Change in vdsm[master]: BZ#734136 - Stricter partition detection

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: BZ#734136 - Stricter partition detection
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

Just minor comment

....................................................
File vdsm/storage/devicemapper.py
Line 102:     dmName = resolveDevName(devName)
Maybe, better to do it right before using, it will sometimes avoid it at all

--
To view, visit http://gerrit.usersys.redhat.com/866
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc242c7a3810efbc89083d0f0ea6fb193a63e331
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com&gt;

Change in vdsm[master]: BZ#734136 - Stricter partition detection

[Yotam Oron]

Yotam Oron has posted comments on this change.

Change subject: BZ#734136 - Stricter partition detection
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/devicemapper.py
Line 32: DM_PREFIX_PARTITION = "Part"
This is not used anywhere.

--
To view, visit http://gerrit.usersys.redhat.com/866
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc242c7a3810efbc89083d0f0ea6fb193a63e331
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com&gt;