Change in vdsm[master]: Add unit tests for misc.py

Saggi Mizrahi has uploaded a new change for review.

Change subject: Add unit tests for misc.py
......................................................................

Add unit tests for misc.py

Change-Id: I44b0fbaf27900daafd0d13af6f003c61ff16369a
---
M tests/Makefile.am
A tests/miscTests.py
2 files changed, 1,082 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/3258/1
--
To view, visit http://gerrit.ovirt.org/3258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I44b0fbaf27900daafd0d13af6f003c61ff16369a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Add unit tests for misc.py
......................................................................


Add unit tests for misc.py

Change-Id: I44b0fbaf27900daafd0d13af6f003c61ff16369a
---
M tests/Makefile.am
A tests/miscTests.py
2 files changed, 1,099 insertions(+), 1 deletion(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Peter V. Saveliev: Verified; Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/3258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I44b0fbaf27900daafd0d13af6f003c61ff16369a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add unit tests for misc.py
......................................................................


Patch Set 8: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44b0fbaf27900daafd0d13af6f003c61ff16369a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Peter V. Saveliev has posted comments on this change.

Change subject: Add unit tests for misc.py
......................................................................


Patch Set 8: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44b0fbaf27900daafd0d13af6f003c61ff16369a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Peter V. Saveliev has posted comments on this change.

Change subject: Add unit tests for misc.py
......................................................................


Patch Set 7: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44b0fbaf27900daafd0d13af6f003c61ff16369a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Peter V. Saveliev has posted comments on this change.

Change subject: Add unit tests for misc.py
......................................................................


Patch Set 6: No score

--
To view, visit http://gerrit.ovirt.org/3258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44b0fbaf27900daafd0d13af6f003c61ff16369a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Peter V. Saveliev has posted comments on this change.

Change subject: Add unit tests for misc.py
......................................................................


Patch Set 6: Fails; I would prefer that you didn't submit this

make[3]: Entering directory `/root/rpmbuild/BUILD/vdsm-4.9.6'
/usr/bin/pyflakes vdsm vdsm_cli vds_bootstrap vdsm_reg vdsm_hooks tests vdsm-tool
tests/miscTests.py:24: 'subprocess' imported but unused
tests/miscTests.py:30: 'binascii' imported but unused
make[3]: *** [check-local] Error 1

--
To view, visit http://gerrit.ovirt.org/3258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44b0fbaf27900daafd0d13af6f003c61ff16369a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add unit tests for misc.py
......................................................................


Patch Set 2: Verified

(3 inline comments)

minor comments can actually wait for a later patch, but still.

....................................................
File tests/miscTests.py
Line 48:         #For backwards compatibility
that's not needed here!

Line 61:         #For backwards compatibility
and neither here, since the tests ships with the code it uses.

Line 73:             sleepProcs.append(misc.execCmd(["sleep", "3"],
sync=False,
but you have defined EXT_SLEEP above, let's use it.

--
To view, visit http://gerrit.ovirt.org/3258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44b0fbaf27900daafd0d13af6f003c61ff16369a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;