Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
Patch Set 2:
Please, read Ayal's comments in http://gerrit.ovirt.org/#/c/21973/
, especially a part
about that removal.
In the bottom line, do you familiar with the PDIV that is not a disk? I think that the
right question is why we have this check there in the first place.
"making this method symmetric to prepare is not what this patch is about. it is about
preventing improper logging that is causing a lot of confusion for users. So symmetry can
be handled separately.
With regards to *how* it should be handled, it looks like the right thing to do is not to
add drive['device'] == 'disk' test here but rather remove it from
In addition, prepare and teardown are not symmetrical in many other ways.
prepareVolumePath is preparing floppies, cdrom etc which teardown is not taking care of.
the 'teardown' for floppy is _cleanupFloppy etc."
To view, visit http://gerrit.ovirt.org/22363
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server