Change in vdsm[master]: BZ#787722 - Make the spm internal lock an RLock

Saggi Mizrahi has uploaded a new change for review.

Change subject: BZ#787722 - Make the spm internal lock an RLock
......................................................................

BZ#787722 - Make the spm internal lock an RLock

This will prevent the object from deadlocking itself when moving between
protected areas in related methdos.

Change-Id: I988553b849b40ca9fe5f3168a3cf75950af4fe14
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/1683/1
--
To view, visit http://gerrit.ovirt.org/1683
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I988553b849b40ca9fe5f3168a3cf75950af4fe14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#787722 - Make the spm internal lock an RLock
......................................................................


Patch Set 1: Looks good to me, approved

Got an answer on irc. Issue introduced by

 commit 4d1dbcdd859be7a16ca0a276076b4a9f6ad5e7fa
 Author: Eduardo Warszawski <ewarszaw(a)redhat.com&gt;
 Date:   Wed Oct 26 14:34:48 2011 +0200

    Fix lock release and reversed SPM logic.
    
    Change-Id: I3e2335163e45dc601d6779b45beb03d67e997692

and happens when stopSpm() is called in an error flow of startSpm()

--
To view, visit http://gerrit.ovirt.org/1683
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988553b849b40ca9fe5f3168a3cf75950af4fe14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#787722 - Make the spm internal lock an RLock
......................................................................


BZ#787722 - Make the spm internal lock an RLock

This will prevent the object from deadlocking itself when moving between
protected areas in related methdos.

Change-Id: I988553b849b40ca9fe5f3168a3cf75950af4fe14
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Haim Ateya: Verified
  Dan Kenigsberg: Looks good to me, approved
  Igor Lvovsky: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/1683
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I988553b849b40ca9fe5f3168a3cf75950af4fe14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#787722 - Make the spm internal lock an RLock
......................................................................


Patch Set 1:

Ancient Tradition claims that the use of RLock to solve self-deadlocking is a sign of
sloppy (original) design. Could you elaborate which call stack is deadlocking itself, and
when it was introduced?

--
To view, visit http://gerrit.ovirt.org/1683
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988553b849b40ca9fe5f3168a3cf75950af4fe14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: BZ#787722 - Make the spm internal lock an RLock
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/1683
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988553b849b40ca9fe5f3168a3cf75950af4fe14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Haim Ateya]

Haim Ateya has posted comments on this change.

Change subject: BZ#787722 - Make the spm internal lock an RLock
......................................................................


Patch Set 1: Verified

On behalf of Dafna - Verified.

--
To view, visit http://gerrit.ovirt.org/1683
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988553b849b40ca9fe5f3168a3cf75950af4fe14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;