From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Refactor JSON RPC exceptions
......................................................................
Patch Set 29:
(1 comment)
https://gerrit.ovirt.org/#/c/78660/29//COMMIT_MSG
Commit Message:
Line 13: For example, new error message for JsonRpcMethodNotFoundError is:
Line 14: The method does not exist or is not available: {'method':
'some_missing_method'}
Line 15:
Line 16: Also added a new class JsonRpcGeneralError, that can have
Line 17: any code and message.
I see... I think, it would be better to put the changes of exceptions
to an
Nir, Seems like you have amazing design and appropriate behavior that you
would like to have in all vdsm code as maintainer - it sounds amazing. but all those
comments can't show me what you want to create - its too long and I can't allow
follow the context. please create design document for your desire of how handling
error\exception should be in vdsm - what way of using this hierarchy is valid and what is
not- like may I create interfaces? can I call super? can I use same message but two
different codes? whatever you love, just write it in a way that we will be able to follow
your way ... if you did so already, please share it and sorry for the interruption :)
Line 18:
Line 19: Change-Id: Ifdaf434aec6c65e7a896e5594fba711193cd2958
--
To view, visit
https://gerrit.ovirt.org/78660
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdaf434aec6c65e7a896e5594fba711193cd2958
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes