Change in vdsm[master]: multiapth: Require newer multiapth version

[Nir Soffer]

Nir Soffer has uploaded a new change for review.

Change subject: multiapth: Require newer multiapth version
......................................................................

multiapth: Require newer multiapth version

Multipath did not identify iscsi devices correctly, so their session
recovery_tmo was not configured correctly. This caused slow failover
when path is having trouble, and may lead to blocking of multiple vdsm
threads for many minutes.

This issue was fixed in device-mapper-multipath-0.4.9-82.el7. We require
now this version.

Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd
Bug-Url: https://bugzilla.redhat.com/1255173
Relates-To: https://bugzilla.redhat.com/880738
Signed-off-by: Nir Soffer 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/45115/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 72e7df6..bc83d72 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -176,7 +176,7 @@
 Requires: sanlock >= 2.8, sanlock-python

%if 0%{?rhel}
-Requires: device-mapper-multipath >= 0.4.9-68
+Requires: device-mapper-multipath >= 0.4.9-82
 Requires: e2fsprogs
 Requires: fence-agents-all
 Requires: kernel >= 3.10.0-132.el7

[e-mail] has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
......................................................................

Patch Set 1:

* Update tracker::#1255173::OK
* Check Bug-Url::OK
* Check Public Bug::#1255173::OK, public bug
* Check Product::#1255173::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
......................................................................

Patch Set 1:

This patch is expected to fail on CI, since the fixed version is not available yet.

[e-mail] has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
......................................................................

Patch Set 2:

* Update tracker::#1255173::OK
* Check Bug-Url::OK
* Check Public Bug::#1255173::OK, public bug
* Check Product::#1255173::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[e-mail] has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
......................................................................

Patch Set 3:

* Update tracker::#1255173::OK
* Check Bug-Url::OK
* Check Public Bug::#1255173::OK, public bug
* Check Product::#1255173::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[e-mail] has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
......................................................................

Patch Set 4:

* Update tracker::#1255173::OK
* Check Bug-Url::OK
* Check Public Bug::#1255173::OK, public bug
* Check Product::#1255173::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[e-mail] has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
......................................................................

Patch Set 5:

* Update tracker::#1255173::OK
* Update tracker::#1256074::OK
* Update tracker::#1261141::OK
* Check Bug-Url::OK
* Check Public Bug::#1255173::OK, public bug
* Check Public Bug::#1256074::OK, public bug
* Check Public Bug::#1261141::OK, public bug
* Check Product::#1255173::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check Product::#1256074::SKIPPED,  and classification Fedora not oVirt
* Check Product::#1261141::SKIPPED,  and classification Fedora not oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[e-mail] has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
......................................................................

Patch Set 6:

* Update tracker::#1255173::OK
* Update tracker::#1256081::OK
* Check Bug-Url::OK
* Check Public Bug::#1255173::OK, public bug
* Check Public Bug::#1256081::OK, public bug
* Check Product::#1255173::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check Product::#1256081::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
......................................................................

Patch Set 6: Code-Review+2

[e-mail] has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
......................................................................

Patch Set 7:

* Update tracker::#1255173::OK
* Update tracker::#1256081::OK
* Check Bug-Url::OK
* Check Public Bug::#1255173::OK, public bug
* Check Public Bug::#1256081::OK, public bug
* Check Product::#1255173::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check Product::#1256081::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
......................................................................

Patch Set 7:

This version changes the if syntax to == instead of =.

[e-mail] has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
......................................................................

Patch Set 8:

* Update tracker::#1255173::OK
* Update tracker::#1256081::OK
* Check Bug-Url::OK
* Check Public Bug::#1255173::OK, public bug
* Check Public Bug::#1256081::OK, public bug
* Check Product::#1255173::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check Product::#1256081::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
......................................................................

Patch Set 7:

Turns out that fedora 21 package is not available yet. It is still in updates-testing repo, so we cannot depend on it yet.

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
......................................................................

Patch Set 8: Verified+1

Tested using the CI rpm install jobs.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
......................................................................

Patch Set 8: Code-Review+2

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: multiapth: Require newer multiapth version
......................................................................

multiapth: Require newer multiapth version

Multipath did not identify iscsi devices correctly, so their session
recovery_tmo was not configured correctly. This caused slow failover
when path is having trouble, and may lead to blocking of multiple vdsm
threads for many minutes.

This issue was fixed in device-mapper-multipath in some of the supported
platforms:

platform        version                 #bug            available
------------------------------------------------------------------
RHEL 7.2        0.4.9-82.el7            bz1254292       yes
RHEL 7.1        0.4.9-77.el7_1.2        bz1267131       yes
Fedora 22       0.4.9-73.fc22.1         bz1256074       yes
Fedora 21       0.4.9-68.fc21.6         bz1261141       no
CentOS          na                      na              no

We require now new version where it is available. We will update the
requirement when the fix is available on other platforms.

Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd
Bug-Url: https://bugzilla.redhat.com/1255173
Bug-Url: https://bugzilla.redhat.com/1256081
Backport-To: 3.6
Backport-To: 3.5
Relates-To: https://bugzilla.redhat.com/880738
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/45115
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M vdsm.spec.in
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved

[e-mail] has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
......................................................................

Patch Set 9:

* Update tracker::#1255173::OK
* Update tracker::#1256081::OK
* Set MODIFIED::bug 1255173::::#1255173::::IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager
* Set MODIFIED::bug 1255173::::bug 1256081::::#1256081::::IGNORE, not oVirt prod but vdsm