Francesco Romani has posted comments on this change.
Change subject: caps: Collect numa information ......................................................................
Patch Set 11:
(2 comments)
Just a few minor things and it is good for me.
http://gerrit.ovirt.org/#/c/23703/11/vdsm/caps.py File vdsm/caps.py:
Line 193: Line 194: Line 195: # Get the memory stats of a specified numa node Line 196: # cell -- int, the index of numa node Line 197: # return value is like {'total': 50321208L, 'free': 47906488L} Nit: the above comment makes more sense as docstring Line 198: @utils.memoized Line 199: def _getMemoryStatsByNumaCell(cell): Line 200: return libvirtconnection.get().getMemoryStats(cell, 0) Line 201:
http://gerrit.ovirt.org/#/c/23703/11/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json:
Line 1087: # @numaNodes: Information about host numa topology Line 1088: # Line 1089: # @numaNodeDistance: Distance information between each two numa nodes Line 1090: # Line 1091: # @autoNumaBalancing: The status of auto numa balancing function Please consider adding an enum here, like e.g. NetworkInterfaceState or anyting else. Probably is better to mimic the one you added in caps.py Line 1092: # Line 1093: # Since: 4.10.0 Line 1094: # Line 1095: # Notes: Since ovirt-engine cannot parse software versions in 'x.y.z' format,
vdsm-patches@lists.fedorahosted.org