4 p.m.
Saggi Mizrahi has uploaded a new change for review.
Change subject: Set the soft limit to be the hard limit so we scale as much as possible
......................................................................
Set the soft limit to be the hard limit so we scale as much as possible
Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
---
M vdsm/vdsm
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/674/1
--
To view, visit http://gerrit.ovirt.org/674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
3:48 p.m.
New subject: Change in vdsm[master]: Set the soft limit to be the hard limit
Ayal Baron has posted comments on this change.
Change subject: Set the soft limit to be the hard limit
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
5 p.m.
New subject: Change in vdsm[master]: Set the soft limit to be the hard limit
Saggi Mizrahi has abandoned this change.
Change subject: Set the soft limit to be the hard limit
......................................................................
Patch Set 4: Abandoned
--
To view, visit http://gerrit.ovirt.org/674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:48 p.m.
New subject: Change in vdsm[master]: Set the soft limit to be the hard limit
Dan Kenigsberg has posted comments on this change.
Change subject: Set the soft limit to be the hard limit
......................................................................
Patch Set 4: I would prefer that you didn't submit this
Saggi, I was asking: what were the actual soft and hard limits of Vdsm before your
change?
I am asking since I find it hard to think why the soft limit was ever less than the hard
limit. vdsmd.init's
ulinit -n bla
should have changed both.
--
To view, visit http://gerrit.ovirt.org/674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:55 a.m.
New subject: Change in vdsm[master]: Set the soft limit to be the hard limit
Igor Lvovsky has posted comments on this change.
Change subject: Set the soft limit to be the hard limit
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:21 p.m.
New subject: Change in vdsm[master]: Set the soft limit to be the hard limit
Saggi Mizrahi has posted comments on this change.
Change subject: Set the soft limit to be the hard limit
......................................................................
Patch Set 3:
What comment? I put it at the beginning of run. Isn't it what you asked for?
--
To view, visit http://gerrit.ovirt.org/674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:03 a.m.
New subject: Change in vdsm[master]: Set the soft limit to be the hard limit
Igor Lvovsky has posted comments on this change.
Change subject: Set the soft limit to be the hard limit
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:37 a.m.
New subject: Change in vdsm[master]: Set the soft limit to be the hard limit
Dan Kenigsberg has posted comments on this change.
Change subject: Set the soft limit to be the hard limit
......................................................................
Patch Set 3:
my comments to patchset 2 have been overlooked.
--
To view, visit http://gerrit.ovirt.org/674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:37 a.m.
New subject: Change in vdsm[master]: Set the soft limit to be the hard limit
Dan Kenigsberg has posted comments on this change.
Change subject: Set the soft limit to be the hard limit
......................................................................
Patch Set 3: I would prefer that you didn't submit this
my comments to patchset 2 have been overlooked.
--
To view, visit http://gerrit.ovirt.org/674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:28 a.m.
New subject: Change in vdsm[master]: Set the soft limit to be the hard limit
Federico Simoncelli has posted comments on this change.
Change subject: Set the soft limit to be the hard limit
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:47 p.m.
New subject: Change in vdsm[master]: Set the soft limit to be the hard limit
Dan Kenigsberg has posted comments on this change.
Change subject: Set the soft limit to be the hard limit
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
fwiw, could tell what was the soft and hard limits before this change?
ulimit -n ...
in vdsmd.init should have set both, as well as http://gerrit.ovirt.org/638
....................................................
File vdsm/vdsm
Line 29: setupLimits()
this file is far from perfectly-written, but calling the new function fits much better
just before calling serve_clients() or before run().
--
To view, visit http://gerrit.ovirt.org/674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:04 p.m.
New subject: Change in vdsm[master]: Set the soft limit to be the hard limit
Ayal Baron has posted comments on this change.
Change subject: Set the soft limit to be the hard limit
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:46 a.m.
Ayal Baron has posted comments on this change.
Change subject: Set the soft limit to be the hard limit so we scale as much as possible
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/vdsm
Line 29: setupLimits()
It's the admins job to raise the hard limit.
the proper way to doing this is dynamically changing this according to number of running
VMs, but due to the fact that the storage subsystem in vdsm runs as part of the same
process then the limit is not only affected by the number of VMs but also by the storage
resources consumed. Therefore a dynamic change is quite difficult to achieve.
In the meanwhile, to scale, we need to match soft and hard.
--
To view, visit http://gerrit.ovirt.org/674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
4:53 p.m.
Adam Litke has posted comments on this change.
Change subject: Set the soft limit to be the hard limit so we scale as much as possible
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/vdsm
Line 29: setupLimits()
I am not saying that this is a bad idea, but I wonder if there's precedence here for
this in a daemon. Isn't it the responsibility of the administrator to set the limits
for the system? In other words, should this be handled by the init script or configured
somewhere else in the system?
--
To view, visit http://gerrit.ovirt.org/674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
4500
days inactive
4515
days old
vdsm-patches@lists.fedorahosted.org
13 comments
6 participants
participants (6)
-
abaron＠redhat.com -
agl＠us.ibm.com -
Dan Kenigsberg -
Federico Simoncelli -
Igor Lvovsky -
smizrahi＠redhat.com