Change in vdsm[master]: BZ#798211 - Normalize hibernation images

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: BZ#798211 - Normalize hibernation images
......................................................................

BZ#798211 - Normalize hibernation images

Change-Id: I1271c5501b129caf28aca7d4be2dbf45d9b32842
---
M vdsm/API.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/2431/1
--
To view, visit http://gerrit.ovirt.org/2431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1271c5501b129caf28aca7d4be2dbf45d9b32842
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#798211 - Normalize hibernation images
......................................................................


BZ#798211 - Normalize hibernation images

Change-Id: I1271c5501b129caf28aca7d4be2dbf45d9b32842
---
M vdsm/API.py
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Ayal Baron: Looks good to me, but someone else must approve
  Haim Ateya: Verified
  Dan Kenigsberg: Looks good to me, approved

Objections:
  Eduardo: I would prefer that you didn't submit this


--
To view, visit http://gerrit.ovirt.org/2431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1271c5501b129caf28aca7d4be2dbf45d9b32842
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#798211 - Normalize hibernation images
......................................................................


Patch Set 1: Looks good to me, approved

Edu, we have a public commitment to solve this ugliness correctly in
http://ovirt.org/wiki/Vdsm_TODO
But let's first unbreak hibernation.

--
To view, visit http://gerrit.ovirt.org/2431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1271c5501b129caf28aca7d4be2dbf45d9b32842
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;

[Haim Ateya]

Haim Ateya has posted comments on this change.

Change subject: BZ#798211 - Normalize hibernation images
......................................................................


Patch Set 1: Verified

ACK

--
To view, visit http://gerrit.ovirt.org/2431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1271c5501b129caf28aca7d4be2dbf45d9b32842
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;

Eduardo has posted comments on this change.

Change subject: BZ#798211 - Normalize hibernation images
......................................................................


Patch Set 1:

Since prophecy is today...
Live snapshot was broken in the same way.
See change #1437.

--
To view, visit http://gerrit.ovirt.org/2431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1271c5501b129caf28aca7d4be2dbf45d9b32842
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;

Eduardo has posted comments on this change.

Change subject: BZ#798211 - Normalize hibernation images
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

Starting a discussion by Igor's request.

....................................................
File vdsm/API.py
Line 552:                     device='disk'), \
This is another hack.
Now, we understand that this flow was broken (by my self) when the conditions of
clientIF.preparePath() were changed to filter out PDIV CDROM.
In this way this will happen again.
It has gone too far and we should not continue to add semantics into this function.
The right thing to do is IMHO to make preparePath() a Drive method.
Make the source ready, be "ready" whatever is required, e.g activate an LV or a
group of LV's, mounting an export , etc, is a source function and it is unrelated to
the flow.

--
To view, visit http://gerrit.ovirt.org/2431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1271c5501b129caf28aca7d4be2dbf45d9b32842
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;

Ayal Baron has posted comments on this change.

Change subject: BZ#798211 - Normalize hibernation images
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/2431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1271c5501b129caf28aca7d4be2dbf45d9b32842
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;