Nir Soffer has uploaded a new change for review.
Change subject: xmlrpc: Improve logging during shutdown
......................................................................
xmlrpc: Improve logging during shutdown
We did not have proper logging when stopping the server, making it hard
to debug. Starting and stopping subsystems should have info level log
messages in the caller thread and in the server thread.
Change-Id: I7cc269213fe89d5033eae173c033970042fc2bce
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/rpc/bindingxmlrpc.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/43194/1
diff --git a/vdsm/rpc/bindingxmlrpc.py b/vdsm/rpc/bindingxmlrpc.py
index e81315a..05110c4 100644
--- a/vdsm/rpc/bindingxmlrpc.py
+++ b/vdsm/rpc/bindingxmlrpc.py
@@ -59,6 +59,7 @@
"""
@utils.traceback(on=self.log.name)
def threaded_start():
+ self.log.info("XMLRPC server running")
self._registerFunctions()
self.server.timeout = 1
self._enabled = True
@@ -70,6 +71,8 @@
if e[0] != EINTR:
self.log.error("xml-rpc handler exception",
exc_info=True)
+ self.log.info("XMLRPC server stopped")
+
self._thread = threading.Thread(target=threaded_start,
name='BindingXMLRPC')
self._thread.daemon = True
@@ -79,6 +82,7 @@
self.server.add(connected_socket, socket_address)
def stop(self):
+ self.log.info("Stopping XMLRPC server")
self._enabled = False
self.server.server_close()
self._thread.join()
--
To view, visit
https://gerrit.ovirt.org/43194
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7cc269213fe89d5033eae173c033970042fc2bce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>