From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: api: provide correlation id
......................................................................
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/75335/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2017-04-07 14:21:35 +0200
Line 4: Commit: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Line 5: CommitDate: 2017-04-07 14:21:35 +0200
Line 6:
Line 7: api: provide correlation id
you provide option field... part of it is the correlation id
Line 8:
Line 9: This patch added new parameter to each verb where we provide correlation
Line 10: id and remote address from where a verb was called. The parameter is a
Line 11: dictionary:
Line 6:
Line 7: api: provide correlation id
Line 8:
Line 9: This patch added new parameter to each verb where we provide correlation
Line 10: id and remote address from where a verb was called. The parameter is a
A caller will now provide those options in each call ? clients now do that?
can't we get the remote address from the connection details?
Line 11: dictionary:
Line 12:
Line 13: {'cid': '2729c8d7',
Line 14: 'remote_addr': 'localhost'}
https://gerrit.ovirt.org/#/c/75335/1/tests/schemavalidation_test.py
File tests/schemavalidation_test.py:
Line 135: default_args = ctor_defaults + self._get_default_args(
Line 136: method_obj)
Line 137:
Line 138: # check len equality
Line 139: if len(args) - 1 != len(method_args):
state in a comment why -1
Line 140: raise AssertionError(self._prep_msg(rep, method_args,
Line 141: args))
Line 142: for marg in method_args:
Line 143: # verify optional arg
--
To view, visit
https://gerrit.ovirt.org/75335
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e73edc929e6d3e55d3f33a51229180ba35c52ac
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes