Change in vdsm[master]: fix getMasterDomain masterVersion handling

Saggi Mizrahi has uploaded a new change for review.

Change subject: fix getMasterDomain masterVersion handling
......................................................................

fix getMasterDomain masterVersion handling

if getMasterDomain() gets -1 as the expected masterVersion it skip
perform the mserterVersion equality test

Change-Id: I2e5dd06800e770c098460466fa8642c5bc928e54
---
M vdsm/storage/sp.py
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/431/1
--
To view, visit http://gerrit.ovirt.org/431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e5dd06800e770c098460466fa8642c5bc928e54
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fix getMasterDomain masterVersion handling
......................................................................


Fix getMasterDomain masterVersion handling

If getMasterDomain() gets -1 as the expected masterVersion it should
skip the masterVersion equality test and accept whatever version is in
the MD.

Change-Id: I2e5dd06800e770c098460466fa8642c5bc928e54
---
M vdsm/storage/sp.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Saggi Mizrahi: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2e5dd06800e770c098460466fa8642c5bc928e54
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Fix getMasterDomain masterVersion handling
......................................................................


Patch Set 11: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5dd06800e770c098460466fa8642c5bc928e54
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Saggi Mizrahi has posted comments on this change.

Change subject: Fix getMasterDomain masterVersion handling
......................................................................


Patch Set 11: Verified

--
To view, visit http://gerrit.ovirt.org/431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5dd06800e770c098460466fa8642c5bc928e54
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: fix getMasterDomain masterVersion handling
......................................................................


Patch Set 10: I would prefer that you didn't submit this

I still do not understand the commit message.

--
To view, visit http://gerrit.ovirt.org/431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5dd06800e770c098460466fa8642c5bc928e54
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: fix getMasterDomain masterVersion handling
......................................................................


Patch Set 8: (1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 661:             os.unlink(self._poolFile)
maybe it's safe here, but I hate test-and-later-set; better unlink and ignore error.

p.s what is it good for? you are soon to overwrite this file anyway.
hmm, the save here does not survive kill-9 before sync. is it bad?

--
To view, visit http://gerrit.ovirt.org/431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5dd06800e770c098460466fa8642c5bc928e54
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Saggi Mizrahi has posted comments on this change.

Change subject: fix getMasterDomain masterVersion handling
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File vdsm/storage/sp.py
Line 662: 
Cut me some slack

Line 1495:         if version != masterVersion and masterVersion != -1:
There are places where we internally don't provide the version. This behavior existed
and was mistakenly removed by someone (might be me)

--
To view, visit http://gerrit.ovirt.org/431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5dd06800e770c098460466fa8642c5bc928e54
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: fix getMasterDomain masterVersion handling
......................................................................


Patch Set 7: I would prefer that you didn't submit this

What about comments from patchset 3

--
To view, visit http://gerrit.ovirt.org/431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5dd06800e770c098460466fa8642c5bc928e54
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: fix getMasterDomain masterVersion handling
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(3 inline comments)

....................................................
Commit Message
Line 10: perform the mserterVersion equality test
mserterVersion  -> masterVersion

....................................................
File vdsm/storage/sp.py
Line 662: 
How this one related to the patch?

Line 1495:         if version != masterVersion and masterVersion != -1:
What is it?   Why?  We expect that master domain has exactly same version as it got. All
other cases should raise exception.

--
To view, visit http://gerrit.ovirt.org/431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5dd06800e770c098460466fa8642c5bc928e54
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: fix getMasterDomain masterVersion handling
......................................................................


Patch Set 9: I would prefer that you didn't submit this

(2 inline comments)

....................................................
Commit Message
Line 9: if getMasterDomain() gets -1 as the expected masterVersion it skip
English parsing error. Could you rewrite what the code should be doing?

....................................................
File vdsm/storage/sp.py
Line 681
this stanza is a part of _saveReconnect as the stuff that you moved around. this
refactoring seems reasonable, but unrelated to the patch and incomplete.

--
To view, visit http://gerrit.ovirt.org/431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5dd06800e770c098460466fa8642c5bc928e54
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;