Change in vdsm[master]: mkimage: set uid/gid right before mkisofs

Francesco Romani has uploaded a new change for review.

Change subject: mkimage: set uid/gid right before mkisofs
......................................................................

mkimage: set uid/gid right before mkisofs

Now that we prepare a file with the right permission
from the start, is worth setting uid/gid right from the
start as well, and not afterwards.

Change-Id: I34dfb486b223d1586480417afba9844e785038e4
Related-To: https://bugzilla.redhat.com/1278414
Signed-off-by: Francesco Romani <fromani(a)redhat.com&gt;
---
M vdsm/mkimage.py
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/48539/1

diff --git a/vdsm/mkimage.py b/vdsm/mkimage.py
index 07757bc..62cddbe 100644
--- a/vdsm/mkimage.py
+++ b/vdsm/mkimage.py
@@ -133,6 +133,10 @@
         # permissions.
         os.open(isopath, os.O_CREAT | os.O_RDWR, mode=0o600)
 
+        os.chown(isopath,
+                 resolveUid(DISKIMAGE_USER),
+                 resolveGid(DISKIMAGE_GROUP))
+
         rc, out, err = execCmd(command, raw=True)
         if rc:
             raise OSError(errno.EIO, "could not create iso file: "


-- 
To view, visit https://gerrit.ovirt.org/48539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I34dfb486b223d1586480417afba9844e785038e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;

gerrit-hooks has posted comments on this change.

Change subject: mkimage: set uid/gid right before mkisofs
......................................................................


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34dfb486b223d1586480417afba9844e785038e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

gerrit-hooks has posted comments on this change.

Change subject: mkimage: set uid/gid right before mkisofs
......................................................................


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34dfb486b223d1586480417afba9844e785038e4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: mkimage: set uid/gid right before mkisofs
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/48539/2/vdsm/mkimage.py
File vdsm/mkimage.py:

Line 137:        os.chown(isopath,
        :                  resolveUid(DISKIMAGE_USER),
        :                  resolveGid(DISKIMAGE_GROUP))
done also in _commonCleanFs. Kept in _commonCleanFs for backward compatibility.


-- 
To view, visit https://gerrit.ovirt.org/48539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34dfb486b223d1586480417afba9844e785038e4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: mkimage: set uid/gid right before mkisofs
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/48539/2/vdsm/mkimage.py
File vdsm/mkimage.py:

Line 135:         os.close(fd)
Line 136: 
Line 137:         os.chown(isopath,
Line 138:                  resolveUid(DISKIMAGE_USER),
Line 139:                  resolveGid(DISKIMAGE_GROUP))
>  done also in _commonCleanFs. Kept in _commonCleanFs for backward
> compatibil 
Should be *after* the command succeeds.
Line 140: 
Line 141:         rc, out, err = execCmd(command, raw=True)
Line 142:         if rc:
Line 143:             raise OSError(errno.EIO, "could not create iso file: "


-- 
To view, visit https://gerrit.ovirt.org/48539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34dfb486b223d1586480417afba9844e785038e4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes