Change in vdsm[master]: Maintain detachSD semantics

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: Maintain detachSD semantics
......................................................................

Maintain detachSD semantics

Before d5ae1d360fa0648f5609a07db2439b0fcc429a44 we did not allow to
detach a master domain if we end up leaving a pool for attached data
domains. This patch suggests to keep this semantics

Change-Id: I39f4d731d7087be63366fa351ac9cf0fa4b1d7db
---
M vdsm/storage/sp.py
1 file changed, 11 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/2057/1
--
To view, visit http://gerrit.ovirt.org/2057
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I39f4d731d7087be63366fa351ac9cf0fa4b1d7db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli

Ayal Baron has posted comments on this change.

Change subject: Maintain detachSD semantics
......................................................................

Patch Set 1: Do not submit

I see no reason for this test.  We currently ignore deactivation of the master domain so preventing deactivate is effectively the same just without throwing an error.  engine has this validation anyway on their side so there is no backward compatibility issue here.

--
To view, visit http://gerrit.ovirt.org/2057
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39f4d731d7087be63366fa351ac9cf0fa4b1d7db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Maintain detachSD semantics
......................................................................

Patch Set 1:

Dan, would you abandon this? I can't do it (maybe because you pushed it). Thanks.

--
To view, visit http://gerrit.ovirt.org/2057
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39f4d731d7087be63366fa351ac9cf0fa4b1d7db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli

[Dan Kenigsberg]

Dan Kenigsberg has abandoned this change.

Change subject: Maintain detachSD semantics
......................................................................

Patch Set 1: Abandoned

ok, ok, please forget my wanting to maintain semantics!

--
To view, visit http://gerrit.ovirt.org/2057
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I39f4d731d7087be63366fa351ac9cf0fa4b1d7db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli