Change in vdsm[master]: BZ#787728 configNet: restore backup on connectivity failure

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: BZ#787728 configNet: restore backup on connectivity failure
......................................................................

BZ#787728 configNet: restore backup on connectivity failure

Change-Id: Ie9ced506a35cae90946813b97b83332d7ecb6aeb
---
M vdsm/configNetwork.py
1 file changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/1686/1
--
To view, visit http://gerrit.ovirt.org/1686
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9ced506a35cae90946813b97b83332d7ecb6aeb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;

[Roy Golan]

Roy Golan has posted comments on this change.

Change subject: BZ#787728 configNet: restore backup on connectivity failure
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 1025:                     for bridge in networksAdded:
pls change bride to network, we're going bridgeless soon!

--
To view, visit http://gerrit.ovirt.org/1686
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9ced506a35cae90946813b97b83332d7ecb6aeb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;

[Roy Golan]

Roy Golan has posted comments on this change.

Change subject: BZ#787728 configNet: restore backup on connectivity failure
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 879:             configWriter.restoreAtomicBackup()
so the restore will be called twice? why? is it re-entrant?

--
To view, visit http://gerrit.ovirt.org/1686
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9ced506a35cae90946813b97b83332d7ecb6aeb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#787728 configNet: restore backup on connectivity failure
......................................................................


BZ#787728 configNet: restore backup on connectivity failure

v2:
    - do not try to call restoreAtomicBackup twice
    - maintain the content of configWriter when changing multiple
      networks

Change-Id: Ie9ced506a35cae90946813b97b83332d7ecb6aeb
---
M vdsm/configNetwork.py
1 file changed, 12 insertions(+), 11 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/1686
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9ced506a35cae90946813b97b83332d7ecb6aeb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#787728 configNet: restore backup on connectivity failure
......................................................................


Patch Set 3: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1686
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9ced506a35cae90946813b97b83332d7ecb6aeb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;

Shahar Havivi has posted comments on this change.

Change subject: BZ#787728 configNet: restore backup on connectivity failure
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/1686
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9ced506a35cae90946813b97b83332d7ecb6aeb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt;