2:31 a.m.
Hello Ayal Baron, Bala.FA, Saggi Mizrahi, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/19863
to review the following change.
Change subject: gluster: fix integer overflow error in rebalance status
......................................................................
gluster: fix integer overflow error in rebalance status
Provides rebalance status values as strings to avoid overflow error
when a rebalance status values exceeds the XML-RPC limits
For more info: https://bugzilla.redhat.com/show_bug.cgi?id=1012393
Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com>
---
M vdsm/gluster/cli.py
1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/19863/1
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index 62b5f13..f9d6404 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -610,21 +610,21 @@
status = {
'summary': {
- 'filesScanned': int(tree.find('aggregate/lookups').text),
- 'filesMoved': int(tree.find('aggregate/files').text),
- 'filesFailed': int(tree.find('aggregate/failures').text),
- 'filesSkipped': int(tree.find('aggregate/failures').text),
- 'totalSizeMoved': int(tree.find('aggregate/size').text),
+ 'filesScanned': tree.find('aggregate/lookups').text,
+ 'filesMoved': tree.find('aggregate/files').text,
+ 'filesFailed': tree.find('aggregate/failures').text,
+ 'filesSkipped': tree.find('aggregate/failures').text,
+ 'totalSizeMoved': tree.find('aggregate/size').text,
'status': tree.find('aggregate/statusStr').text.upper()},
'hosts': []}
for el in tree.findall('node'):
status['hosts'].append({'name':
el.find('nodeName').text,
- 'filesScanned':
int(el.find('lookups').text),
- 'filesMoved':
int(el.find('files').text),
- 'filesFailed':
int(el.find('failures').text),
- 'filesSkipped':
int(el.find('failures').text),
- 'totalSizeMoved':
int(el.find('size').text),
+ 'filesScanned': el.find('lookups').text,
+ 'filesMoved': el.find('files').text,
+ 'filesFailed': el.find('failures').text,
+ 'filesSkipped':
el.find('failures').text,
+ 'totalSizeMoved': el.find('size').text,
'status':
el.find('statusStr').text.upper()})
return status
--
To view, visit http://gerrit.ovirt.org/19863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
5 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: fix integer overflow error in rebalance status
......................................................................
Patch Set 4: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:32 a.m.
Timothy Asir has posted comments on this change.
Change subject: gluster: fix integer overflow error in rebalance status
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/19863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:21 a.m.
Timothy Asir has posted comments on this change.
Change subject: gluster: fix integer overflow error in rebalance status
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/19863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:33 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: fix integer overflow error in rebalance status
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4691/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4767/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3882/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/19863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:56 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: fix integer overflow error in rebalance status
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4693/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4769/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3884/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/19863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:38 a.m.
Bala.FA has posted comments on this change.
Change subject: gluster: fix integer overflow error in rebalance status
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:34 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: fix integer overflow error in rebalance status
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4694/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4770/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3885/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/19863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:57 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: fix integer overflow error in rebalance status
......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4703/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4779/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3894/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/19863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: fix integer overflow error in rebalance status
......................................................................
gluster: fix integer overflow error in rebalance status
Provides rebalance status values as strings to avoid overflow error
when a rebalance status values exceeds the XML-RPC limits
Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1012393
Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/19863
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Tested-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/glusterTestData.py
M vdsm/gluster/cli.py
2 files changed, 30 insertions(+), 30 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:42 p.m.
Timothy Asir has posted comments on this change.
Change subject: gluster: fix integer overflow error in rebalance status
......................................................................
Patch Set 3:
(1 comment)
....................................................
Commit Message
Line 8:
Line 9: Provides rebalance status values as strings to avoid overflow error
Line 10: when a rebalance status values exceeds the XML-RPC limits
Line 11:
Line 12: For more info: https://bugzilla.redhat.com/show_bug.cgi?id=1012393
Done
Line 13:
Line 14: Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
--
To view, visit http://gerrit.ovirt.org/19863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
7:36 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: fix integer overflow error in rebalance status
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
Code seems fine, thought please fix the commit message.
....................................................
Commit Message
Line 8:
Line 9: Provides rebalance status values as strings to avoid overflow error
Line 10: when a rebalance status values exceeds the XML-RPC limits
Line 11:
Line 12: For more info: https://bugzilla.redhat.com/show_bug.cgi?id=1012393
use the Bug-Url: format, please.
Line 13:
Line 14: Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
--
To view, visit http://gerrit.ovirt.org/19863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec44c47268318bcc105c00c2de0cf483012d3723
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
3857
days inactive
3857
days old
vdsm-patches@lists.fedorahosted.org
11 comments
4 participants
participants (4)
-
barumuga＠redhat.com -
Dan Kenigsberg -
Jenkins CI RO -
tjeyasin＠redhat.com