4:19 p.m.
Saggi Mizrahi has uploaded a new change for review.
Change subject: InvalidParameterException() takes two args
......................................................................
InvalidParameterException() takes two args
Change-Id: Id725f20ecf2836ab73bb8ae28ed0550574365fe7
---
M vdsm/storage/storage_connection.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/432/1
--
To view, visit http://gerrit.ovirt.org/432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id725f20ecf2836ab73bb8ae28ed0550574365fe7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
11:07 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: InvalidParameterException() takes two args
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/storage_connection.py
Line 84: raise se.InvalidParameterException(paramName, 'parameter
"%s" is missing from connection info %s' % (paramName, con.get('id',
"")))
If you already do this great job, can you please fix it in on places.
I still see it in ddWatchCopy() in misc.py
--
To view, visit http://gerrit.ovirt.org/432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id725f20ecf2836ab73bb8ae28ed0550574365fe7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:49 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: InvalidParameterException() takes two args
......................................................................
InvalidParameterException() takes two args
Change-Id: Id725f20ecf2836ab73bb8ae28ed0550574365fe7
---
M vdsm/storage/hsm.py
M vdsm/storage/misc.py
M vdsm/storage/storage_connection.py
3 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id725f20ecf2836ab73bb8ae28ed0550574365fe7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:49 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: InvalidParameterException() takes two args
......................................................................
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id725f20ecf2836ab73bb8ae28ed0550574365fe7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:39 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: InvalidParameterException() takes two args
......................................................................
Patch Set 4: I would prefer that you didn't submit this
how about solving all three occurances?
--
To view, visit http://gerrit.ovirt.org/432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id725f20ecf2836ab73bb8ae28ed0550574365fe7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:11 p.m.
Saggi Mizrahi has posted comments on this change.
Change subject: InvalidParameterException() takes two args
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/storage/storage_connection.py
Line 84: raise se.InvalidParameterException(paramName, 'parameter
"%s" is missing from connection info %s' % (paramName, con.get('id',
"")))
Why not, if you just print the string you would have no way of knowing what the parameter
was
--
To view, visit http://gerrit.ovirt.org/432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id725f20ecf2836ab73bb8ae28ed0550574365fe7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:51 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: InvalidParameterException() takes two args
......................................................................
Patch Set 3: I would prefer that you didn't submit this
Saggi, look at my previous comment on patchset 2
Dan, look at misk.py
def ddWatchCopy(....)
....
raise se.InvalidParameterException("size = %s, offset = %s" % (size, offset))
--
To view, visit http://gerrit.ovirt.org/432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id725f20ecf2836ab73bb8ae28ed0550574365fe7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:43 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: InvalidParameterException() takes two args
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
btw, same bug exists at hsm.public_moveImage.
Igor, I do not notice this elsewhere.
....................................................
File vdsm/storage/storage_connection.py
Line 84: raise se.InvalidParameterException(paramName, 'parameter
"%s" is missing from connection info %s' % (paramName, con.get('id',
"")))
It could have been even better if you had dropped the param name form the string. why
repeat it in the final log line?
--
To view, visit http://gerrit.ovirt.org/432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id725f20ecf2836ab73bb8ae28ed0550574365fe7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4525
days inactive
4533
days old
vdsm-patches@lists.fedorahosted.org
7 comments
3 participants
participants (3)
-
Dan Kenigsberg -
Igor Lvovsky -
smizrahi＠redhat.com