Change in vdsm[master]: Report sanlock not configured when sanlock is down

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Report sanlock not configured when sanlock is down
......................................................................

Report sanlock not configured when sanlock is down

If sanlock is down we cannot assume that sanlock process is already
related to the supplementary group. Configure verb won't configure
sanlock if isconfigure return True. Therefore, this patch change the
return to False so 'vdsm-tool configure' will perform the usermod
action.

Change-Id: I0bb3125e64cf02e55738f5978fd81d605dd84d38
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057225
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M lib/vdsm/tool/configurator.py
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/24007/1

diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index dfc4115..fc893ea 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -163,7 +163,13 @@
         except IOError as e:
             if e.errno == os.errno.ENOENT:
                 sys.stdout.write("sanlock service is not running\n")
-                configured = True
+                # if sanlock service is not running we cannot check if
+                # sanlock process is related to the desired
+                # supplementary groups.
+                # Therefore, we return False to run the sanlock configure which
+                # performs the usermod action. Running it even if configured
+                # already won't harm, but not running it will.
+                configured = False
             else:
                 raise
 


-- 
To view, visit http://gerrit.ovirt.org/24007
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bb3125e64cf02e55738f5978fd81d605dd84d38
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Report sanlock not configured when sanlock is down
......................................................................


Patch Set 1: Verified+1 Code-Review+1

Worked for me.

-- 
To view, visit http://gerrit.ovirt.org/24007
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bb3125e64cf02e55738f5978fd81d605dd84d38
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-HasComments: No

Change in vdsm[master]: Adding configure sanlock on force

[Sandro Bonazzola]

Sandro Bonazzola has posted comments on this change.

Change subject: Adding configure sanlock on force
......................................................................


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/24007
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bb3125e64cf02e55738f5978fd81d605dd84d38
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-HasComments: No

Change in vdsm[master]: Adding configure sanlock on force

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding configure sanlock on force
......................................................................


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6240/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7130/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7019/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/24007
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bb3125e64cf02e55738f5978fd81d605dd84d38
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: Adding configure sanlock on force

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Adding configure sanlock on force
......................................................................


Adding configure sanlock on force

If sanlock is down we cannot check sanlock process, so isconfigure return that
sanlock process is already related to the supplementary group.
Configure verb won't configure sanlock if isconfigure return True currently.
Therefore, this patch change the ConfigureOnForce to True so
'vdsm-tool configure --force' will perform the usermod action as the
user expected.

Change-Id: I0bb3125e64cf02e55738f5978fd81d605dd84d38
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057225
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/24007
Reviewed-by: Sandro Bonazzola <sbonazzo(a)redhat.com&gt;
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M lib/vdsm/tool/configurator.py
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Sandro Bonazzola: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24007
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0bb3125e64cf02e55738f5978fd81d605dd84d38
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: Adding configure sanlock on force

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Adding configure sanlock on force
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/24007
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bb3125e64cf02e55738f5978fd81d605dd84d38
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: Adding configure sanlock on force

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding configure sanlock on force
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6161/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7054/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6948/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/24007
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bb3125e64cf02e55738f5978fd81d605dd84d38
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Change in vdsm[master]: Adding configure sanlock on force

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding configure sanlock on force
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/24007
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bb3125e64cf02e55738f5978fd81d605dd84d38
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-HasComments: No

[Sandro Bonazzola]

Sandro Bonazzola has posted comments on this change.

Change subject: Report sanlock not configured when sanlock is down
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/24007
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bb3125e64cf02e55738f5978fd81d605dd84d38
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt;
Gerrit-HasComments: No