2:12 p.m.
Alon Bar-Lev has uploaded a new change for review.
Change subject: utils: add ovirt-node persistence functions
......................................................................
utils: add ovirt-node persistence functions
Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M lib/vdsm/utils.py
1 file changed, 24 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/20811/1
diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index 78d055e..acb284c 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -877,3 +877,27 @@
logging.error("Panic: %s", msg, exc_info=True)
os.killpg(0, 9)
sys.exit(-3)
+
+
+@memoized
+def isOvirtNode():
+ return (
+ os.path.exists('/etc/rhev-hypervisor-release') or
+ glob.glob('/etc/ovirt-node-*-release')
+ )
+
+
+def ovirtNodePersist(files):
+ if isOvirtNode():
+ from ovirtnode import ovirtfunctions
+ ovirtfunctions.ovirt_store_config(files)
+
+
+def ovirtNodeUnpersist(files):
+ if isOvirtNode():
+ from ovirtnode import ovirtfunctions
+ todo = []
+ for f in files:
+ if ovirtfunctions.is_persisted(f):
+ todo.append(f)
+ ovirtfunctions.remove_config([todo])
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
5:04 p.m.
Alon Bar-Lev has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 2:
(1 comment)
....................................................
File lib/vdsm/utils.py
Line 900: if isOvirtNode():
Line 901: from ovirtnode import ovirtfunctions
Line 902: for f in files:
Line 903: if ovirtfunctions.is_persisted(f):
Line 904: ovirtfunctions.remove_config([f])
I am unsure... I believe we use:
http://gerrit.ovirt.org/gitweb?p=ovirt-node.git;a=blob;f=scripts/ovirt-fu...
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
4:55 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 2:
(1 comment)
....................................................
File lib/vdsm/utils.py
Line 900: if isOvirtNode():
Line 901: from ovirtnode import ovirtfunctions
Line 902: for f in files:
Line 903: if ovirtfunctions.is_persisted(f):
Line 904: ovirtfunctions.remove_config([f])
We already rely on it, albeit via the mediation of execCmd...
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
2:34 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
....................................................
File lib/vdsm/utils.py
Line 900: if isOvirtNode():
Line 901: from ovirtnode import ovirtfunctions
Line 902: for f in files:
Line 903: if ovirtfunctions.is_persisted(f):
Line 904: ovirtfunctions.remove_config([f])
I have no smart suggestions. I feel awkward with the asymmetry between the persist and in
persist function.
I do not think it matters that much, though.
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
4:32 p.m.
Alon Bar-Lev has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 2:
(3 comments)
....................................................
File lib/vdsm/utils.py
Line 890: def ovirtNodePersist(files):
Line 891: if isOvirtNode():
Line 892: from ovirtnode import ovirtfunctions
Line 893: for f in files:
Line 894: if not ovirtfunctions.is_persisted(f):
well, this is what I initially did... but:
1. it produces warning into the ovirt log.
2. we cannot know which file had error.
3. as much as I can read the function[1], it is so bad that I cannot understand when it
returns true or false...
so I decided to revert into the safest path possible.
[1]
http://gerrit.ovirt.org/gitweb?p=ovirt-node.git;a=blob;f=scripts/ovirtfun...
Line 895: if not ovirtfunctions.ovirt_store_config([f]):
Line 896: raise RuntimeError("Cannot persist '%s'" %
f)
Line 897:
Line 898:
Line 892: from ovirtnode import ovirtfunctions
Line 893: for f in files:
Line 894: if not ovirtfunctions.is_persisted(f):
Line 895: if not ovirtfunctions.ovirt_store_config([f]):
Line 896: raise RuntimeError("Cannot persist '%s'" %
f)
it is soooooooooooo bad.
Line 897:
Line 898:
Line 899: def ovirtNodeUnpersist(files):
Line 900: if isOvirtNode():
Line 900: if isOvirtNode():
Line 901: from ovirtnode import ovirtfunctions
Line 902: for f in files:
Line 903: if ovirtfunctions.is_persisted(f):
Line 904: ovirtfunctions.remove_config([f])
I thought of ignoring this one... the warning is available at ovirt log... and there is no
consistent return code[1]
what do you suggest?
[1]
http://gerrit.ovirt.org/gitweb?p=ovirt-node.git;a=blob;f=scripts/ovirtfun...
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
4:25 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 2:
(3 comments)
....................................................
File lib/vdsm/utils.py
Line 890: def ovirtNodePersist(files):
Line 891: if isOvirtNode():
Line 892: from ovirtnode import ovirtfunctions
Line 893: for f in files:
Line 894: if not ovirtfunctions.is_persisted(f):
is there any danger of calling ovirt_store_config() on an already-persisted file? I find
it odd that we need our own semantics around "persist".
Line 895: if not ovirtfunctions.ovirt_store_config([f]):
Line 896: raise RuntimeError("Cannot persist '%s'" %
f)
Line 897:
Line 898:
Line 892: from ovirtnode import ovirtfunctions
Line 893: for f in files:
Line 894: if not ovirtfunctions.is_persisted(f):
Line 895: if not ovirtfunctions.ovirt_store_config([f]):
Line 896: raise RuntimeError("Cannot persist '%s'" %
f)
ovirt_store_config does not raise on error? lovely.
Line 897:
Line 898:
Line 899: def ovirtNodeUnpersist(files):
Line 900: if isOvirtNode():
Line 900: if isOvirtNode():
Line 901: from ovirtnode import ovirtfunctions
Line 902: for f in files:
Line 903: if ovirtfunctions.is_persisted(f):
Line 904: ovirtfunctions.remove_config([f])
do we need to check the return value here? I see that remove_config() can return True,
False or None. (no idea why)
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
6:13 p.m.
Itamar Heim has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 2:
ping
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:39 p.m.
Alon Bar-Lev has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 2:
(1 comment)
....................................................
File lib/vdsm/utils.py
Line 900: if isOvirtNode():
Line 901: from ovirtnode import ovirtfunctions
Line 902: for f in files:
Line 903: if ovirtfunctions.is_persisted(f):
Line 904: ovirtfunctions.remove_config([f])
but do you understand the code of ovirt-node? I just do not think we can relay on its
return value.
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10:40 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:34 a.m.
Alon Bar-Lev has abandoned this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Abandoned
ok... dropping this patch.
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:33 a.m.
Saggi Mizrahi has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
again, I do not mind dropping this patch... I already told mooli I
will be
I want one method used. And the one that the node people recommend. If
there isn't a consensus I don't mind just execCmd the persist\unpersist CLI
command like the rest of VDSM.
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10:29 a.m.
Alon Bar-Lev has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 4:
mooli, feel free to drop this one in favour of whatever you agree... I will use whatever
within vdsm in future host-deploy work.
I just sorry I did not have time to complete it back then.
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:26 a.m.
mooli tayer has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
again, I do not mind dropping this patch... I already told mooli I
will be
There is no disagreement about isOvirtNode(). we will
benefit if you would separate to two different patches.
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10:04 a.m.
Alon Bar-Lev has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
Maybe you could just use the new imports like in:
again, I do
not mind dropping this patch... I already told mooli I will be surprised.
if we are to use the new node api, this should be horizontal patch throughout vdsm, with
extensive testing.
up until that point, I suggest we use the old known evil.
your call.
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10 a.m.
Saggi Mizrahi has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
ok, I wanted to avoid even try to import this code which is not the
best on
Maybe you could just use the new imports like in:
http://gerrit.ovirt.org/#/c/28463/1/lib/vdsm/tool/configfile.py,cm
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
9:53 a.m.
Alon Bar-Lev has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
I was going to suggest moving the import to the top
ok, I
wanted to avoid even try to import this code which is not the best one... see[1]
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1080974
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
9:47 a.m.
Saggi Mizrahi has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
the reason was not to check the node each time and not to import the
ovirtf
I was going to suggest moving the import to the top
of the file.
ovirtfunctions = None
if isOvirtNode() then
from ovirtnode import ovirtfunctions
or
try:
from ovirtnode import ovirtfunctions
except ImportError:
ovirtfunctions = None
further more isOvirtNode() is memoized so it's
not really that much of a performance hit to
merit a style break
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
8:51 a.m.
Alon Bar-Lev has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
The function should operate on a single file.
the reason was
not to check the node each time and not to import the ovirtfunctions each time. please
confirm again your request.
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
8:42 a.m.
Saggi Mizrahi has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
please add short comment what persist means in this scope, and what
unpersi
The function should operate on a single file.
If there is no advantage to batching you should let the caller do the loop as you are
needlessly forcing the caller to have the files as an iterable.
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
8:11 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
please add short comment what persist means in this scope, and what unpersist allows you
to do and why it is useful
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
4:48 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9769/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8831/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9616/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs... :
SUCCESS
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:39 a.m.
Alon Bar-Lev has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 4:
ovirtNodePersist - if you add a new file at /etc, please be aware that once it is
persisted you can only modify file in place, you cannot rename or move file into
ovirtNodeUnPersist - if you want to remove a file at /etc
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:35 a.m.
mooli tayer has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 4:
It is not clear to me when ovirtNodePersist and ovirtNodeUnpersist
should be called. could you explain about it in the doc string?
Should ovirtNodePersist be called when calling chmod?
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:19 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9763/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8825/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9610/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs... :
SUCCESS
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:08 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 3: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9761/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8823/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9608/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs... :
SUCCESS
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:03 a.m.
Alon Bar-Lev has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 3:
rebase
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:40 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4382/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5186/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5263/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:35 p.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:14 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4381/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5185/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5261/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:14 p.m.
Alon Bar-Lev has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 1:
OK... got the hint... patch[1] can use this interface.
[1] http://gerrit.ovirt.org/#/c/20809/
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-HasComments: No
2:47 p.m.
Alon Bar-Lev has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 2:
ping?
when I have time to verify the entire node thing, together with registration.
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:44 p.m.
Itamar Heim has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
......................................................................
Patch Set 2:
ping?
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3403
days inactive
3621
days old
vdsm-patches@lists.fedorahosted.org
31 comments
7 participants
participants (7)
-
Alon Bar-Lev -
Dan Kenigsberg -
iheim＠redhat.com -
Jenkins CI RO -
mtayer＠redhat.com -
smizrahi＠redhat.com -
ybronhei＠redhat.com