From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: wip:dpdk: add dpdkvhostuser port
......................................................................
Patch Set 8: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/74327/8/lib/vdsm/network/ovs/switch.py
File lib/vdsm/network/ovs/switch.py:
Line 69: transaction = ovsdb.transaction()
Line 70: with transaction:
Line 71: transaction.add(ovsdb.add_port(bridge, port))
Line 72: transaction.add(ovsdb.set_vhostuser_port(bridge, port))
Line 73:
please hide in a private function and add a link to the OvS bug fixinging the need for
that (and explaining the security problem here)
Line 74: uid = pwd.getpwnam("qemu").pw_uid
Line 75: gid = grp.getgrnam("kvm").gr_gid
Line 76: os.chown('/var/run/openvswitch/{}'.format(port), uid, gid)
Line 77:
https://gerrit.ovirt.org/#/c/74327/8/lib/vdsm/virt/vmdevices/network.py
File lib/vdsm/virt/vmdevices/network.py:
PS8, Line 197: vdsm.conf
I don't see us ever configuring a different path to ovs directory. But having a
properly-named constant for this sounds right.
PS8, Line 198: .format
os.path.join() is better fitting.
--
To view, visit
https://gerrit.ovirt.org/74327
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81cf52f17ffe01713dd6502d68c4b17c64e5335
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes